From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Mike Galbraith <umgwanakikbuti@gmail.com>,
Minchan Kim <minchan@kernel.org>, Nitin Gupta <ngupta@vflare.org>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
RT <linux-rt-users@vger.kernel.org>
Subject: Re: [rfc patch] drivers/block/zram: Replace bit spinlocks with rtmutex for -rt
Date: Wed, 30 Mar 2016 18:13:02 +0900 [thread overview]
Message-ID: <20160330091302.GB2769@swordfish> (raw)
In-Reply-To: <20160330085622.GA21849@linutronix.de>
On (03/30/16 10:56), Sebastian Andrzej Siewior wrote:
[..]
> >+static inline void zram_unlock_table(struct zram_table_entry *table)
> >+{
> >+ __clear_bit(ZRAM_ACCESS, &table->value);
> >+ spin_unlock(&table->lock);
> >+}
>
> ZRAM_ACCESS is the only bit used for locking. ZRAM_ZERO is the only flag
> set / tested.
> Would it be possible to make value u32 and add a spinlock? value is has
> not 64bit on 64bit systems and it uses only the first 23bits for the
> size and bit 24+25 for the two flags we have now. So the size should not
> change on 64bit systems only increase by four byte on 32bit systems.
> That is without the lock debugging of course.
>
> Minchan, Nitin, Sergey do see any reason not to do so?
that's increased size for every table entry + lock debugging bloat;
not exactly what zram is trying to do. sounds bad enough.
-ss
next prev parent reply other threads:[~2016-03-30 9:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 10:19 [rfc patch] drivers/block/zram: Replace bit spinlocks with rtmutex for -rt Mike Galbraith
2016-03-22 10:34 ` Mike Galbraith
2016-03-30 8:56 ` Sebastian Andrzej Siewior
2016-03-30 9:13 ` Sergey Senozhatsky [this message]
2016-03-30 9:19 ` Sebastian Andrzej Siewior
2016-03-30 9:23 ` Mike Galbraith
2016-03-31 2:08 ` Mike Galbraith
2016-04-01 10:42 ` Sebastian Andrzej Siewior
2016-04-04 0:27 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160330091302.GB2769@swordfish \
--to=sergey.senozhatsky.work@gmail.com \
--cc=bigeasy@linutronix.de \
--cc=linux-rt-users@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=umgwanakikbuti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.