All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Rasesh Mody <rasesh.mody@qlogic.com>
Cc: <bruce.richardson@intel.com>, <thomas.monjalon@6wind.com>,
	<dev@dpdk.org>, <ameen.rahman@qlogic.com>,
	<harish.patil@qlogic.com>, <sony.chacko@qlogic.com>
Subject: Re: [PATCH v4 05/10] qede: Add core driver
Date: Wed, 30 Mar 2016 09:47:57 -0700	[thread overview]
Message-ID: <20160330094757.253c012a@xeon-e3> (raw)
In-Reply-To: <1459315705-25001-6-git-send-email-rasesh.mody@qlogic.com>

On Tue, 29 Mar 2016 22:28:20 -0700
Rasesh Mody <rasesh.mody@qlogic.com> wrote:

> +static void qede_config_accept_any_vlan(struct qede_dev *qdev, bool action)
> +{
> +	struct ecore_dev *edev = &qdev->edev;
> +	struct qed_update_vport_params params;
> +	int rc;
> +
> +	/* Proceed only if action actually needs to be performed */
> +	if (qdev->accept_any_vlan == action)
> +		return;
> +
> +	memset(&params, 0, sizeof(params));
> +
> +	params.vport_id = 0;
> +	params.accept_any_vlan = action;
> +	params.update_accept_any_vlan_flg = 1;

Minor nit. A lot of this code uses memset() then sets structure elements.
Why not just use C99 style initialization:

	struct qed_update_vport_params params = {
		.vport_id = 0,
		.accept_any_vlan = action,
		.update_accept_any_vlan = 1,
	};

  parent reply	other threads:[~2016-03-30 16:47 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-30  5:28 [PATCH v4 00/10] qede: Add qede PMD Rasesh Mody
2016-03-30  5:28 ` [PATCH v4 01/10] qede: Add maintainers Rasesh Mody
2016-03-30  5:28 ` [PATCH v4 02/10] qede: Add documentation Rasesh Mody
2016-03-30  5:28 ` [PATCH v4 03/10] qede: Add license file Rasesh Mody
2016-03-30  5:28 ` [PATCH v4 04/10] qede: Add base driver Rasesh Mody
2016-03-30  5:28 ` [PATCH v4 05/10] qede: Add core driver Rasesh Mody
2016-03-30 16:39   ` Stephen Hemminger
2016-03-30 22:16     ` Harish Patil
2016-03-30 22:37       ` Stephen Hemminger
2016-03-31 19:36         ` Harish Patil
2016-03-31 21:51           ` Stephen Hemminger
2016-03-30 16:40   ` Stephen Hemminger
2016-03-30 22:23     ` Harish Patil
2016-03-30 16:42   ` Stephen Hemminger
2016-03-30 16:43   ` Stephen Hemminger
2016-03-30 16:45   ` Stephen Hemminger
2016-03-31  7:03     ` Harish Patil
2016-03-30 16:47   ` Stephen Hemminger [this message]
2016-03-30 16:49   ` Stephen Hemminger
2016-03-30  5:28 ` [PATCH v4 06/10] qede: Add L2 support Rasesh Mody
2016-03-30  5:28 ` [PATCH v4 07/10] qede: Add SRIOV support Rasesh Mody
2016-03-30  5:28 ` [PATCH v4 08/10] qede: Add attention support Rasesh Mody
2016-03-30  5:28 ` [PATCH v4 09/10] qede: Add DCBX support Rasesh Mody
2016-03-30  5:28 ` [PATCH v4 10/10] qede: Enable PMD build Rasesh Mody

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160330094757.253c012a@xeon-e3 \
    --to=stephen@networkplumber.org \
    --cc=ameen.rahman@qlogic.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=harish.patil@qlogic.com \
    --cc=rasesh.mody@qlogic.com \
    --cc=sony.chacko@qlogic.com \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.