Re: [PATCH v2 1/7] tpm/tpm_atmel: drop remaining 'iobase' usage

[Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>]

On Tue, Mar 29, 2016 at 04:45:40PM +0200, Christophe Ricard wrote:
> Hi Jarkko,
> 
> I just saw you have updated the master branch removing patch:
> tpm: drop 'iobase' from struct tpm_vendor_specific.
> 
> I will merge both in a new v3 serie and will make sure it will build for
> PPC64
> as well.
> 
> Does that sound acceptable for you ?

It does. No worries.

> Best Regards
> Christophe

/Jarkko

> 
> On 29/03/2016 16:08, Jarkko Sakkinen wrote:
> >On Sat, Mar 26, 2016 at 08:00:09AM +0100, Christophe Ricard wrote:
> >>Remove some sporadic iobase
> >This description of this commit is total crap to be honest (saying
> >this with a polite tone but that's how it is). For me the commit meessage
> >is the most important part of the commit and the sentence above contains
> >exactly zero amount of information.
> >
> >A proper commit message would have stated that this fixes the PPC64
> >builds that your earlier patch breaks. Have you tested that PPC64 builds
> >work now?
> >
> >Actually what you should have *really* done would have updated your
> >older patch and put a remark into change log in the cover letter.
> >
> >/Jarkko
> >
> >>Signed-off-by: Christophe Ricard <christophe-h.ricard-qxv4g6HH51o@public.gmane.org>
> >>---
> >>  drivers/char/tpm/tpm_atmel.h | 4 ++--
> >>  1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >>diff --git a/drivers/char/tpm/tpm_atmel.h b/drivers/char/tpm/tpm_atmel.h
> >>index c5618ea..7e37c16 100644
> >>--- a/drivers/char/tpm/tpm_atmel.h
> >>+++ b/drivers/char/tpm/tpm_atmel.h
> >>@@ -38,8 +38,8 @@ static inline struct tpm_atmel_priv *atmel_get_priv(struct tpm_chip *chip)
> >>  #include <asm/prom.h>
> >>-#define atmel_getb(chip, offset) readb(chip->vendor->iobase + offset);
> >>-#define atmel_putb(val, chip, offset) writeb(val, chip->vendor->iobase + offset)
> >>+#define atmel_getb(priv, offset) readb(priv->iobase + offset);
> >>+#define atmel_putb(val, priv, offset) writeb(val, priv->iobase + offset)
> >>  #define atmel_request_region request_mem_region
> >>  #define atmel_release_region release_mem_region
> >>-- 
> >>2.5.0
> >>
> 

------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785471&iu=/4140