From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH] drm/atmel: Fixup drm_connector_/unplug/unregister/_all Date: Wed, 30 Mar 2016 14:34:40 +0200 Message-ID: <20160330123440.GB2329@ulmo> References: <1459254098-1278-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0600148377==" Return-path: Received: from mail-wm0-x22f.google.com (mail-wm0-x22f.google.com [IPv6:2a00:1450:400c:c09::22f]) by gabe.freedesktop.org (Postfix) with ESMTPS id D025D6E7C7 for ; Wed, 30 Mar 2016 12:34:44 +0000 (UTC) Received: by mail-wm0-x22f.google.com with SMTP id r72so97531503wmg.0 for ; Wed, 30 Mar 2016 05:34:44 -0700 (PDT) In-Reply-To: <1459254098-1278-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Daniel Vetter , Alexey Brodkin , DRI Development List-Id: dri-devel@lists.freedesktop.org --===============0600148377== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="1LKvkjL3sHcu1TtY" Content-Disposition: inline --1LKvkjL3sHcu1TtY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 29, 2016 at 02:21:38PM +0200, Daniel Vetter wrote: > Accidentally fell through the cracks in >=20 > commit 6c87e5c3ec6db052f3744804a517b6fb003906e1 > Author: Alexey Brodkin > Date: Wed Mar 23 11:42:54 2016 +0300 >=20 > drm: Rename drm_connector_unplug_all() to drm_connector_unregister_al= l() >=20 > despite that Boris acked that patch. >=20 > Cc: Boris Brezillon > Cc: Alexey Brodkin > Acked-by: Boris Brezillon > Reported-by: kbuild test robot > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c b/drivers/gpu/d= rm/atmel-hlcdc/atmel_hlcdc_dc.c > index 3d8d16402d07..8ab4318e57a1 100644 > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c > @@ -615,7 +615,7 @@ err: > static void atmel_hlcdc_dc_connector_unplug_all(struct drm_device *dev) > { > mutex_lock(&dev->mode_config.mutex); > - drm_connector_unplug_all(dev); > + drm_connector_unregister_all(dev); > mutex_unlock(&dev->mode_config.mutex); > } > =20 I think the locking here is completely unnecessary, since drm_connector_unregister_all() doesn't actually do anything with the connector object as far as DRM device is concerned, it merely removes it =66rom sysfs and debugfs. But given that I sent out almost the same patch earlier, and this does fix a build failure: Reviewed-by: Thierry Reding --1LKvkjL3sHcu1TtY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJW+8fgAAoJEN0jrNd/PrOht1kQAJ7W93L3s112rhnYhLKgN2Az F5t2euiDBBSdw5RTdOLmXsEqTA8R+6uhx3j5DeihHAw1XEVGvgQf/VO5VV7Qg4iZ VAlJI90pwqCF7zCZ6xx3Gl9ly15WckEqLc9KqG8IhJcAtmSFniKTY/wby5oKOfPi 4AtZsHIpHecpkO+Ld6ZYew8fpamNJlmAHpmie9O/f4eqOfJuXFv9DjVIfwtm/FJH 7huvp7mFoiNk1p7RvQRjgLxNfKx1LWMJ/8LswptpyMc7v6/VUeivEDJAwUg7fgbX 26HQRonf0UwykzRdsavNydmmGUnA0PYqt/2otGoQBqeqS8DDmg+R7Iz3cbc+G7uX mLD3MTtoHEAip3bpdmA2SkX9tTG3sh7lioZYUi9wQhilRHk8MCca7FBhKDWQnNPx pXjI3UuJNoM9czscSmVuL1i2O3ibW1J3YiEw/wZ3wL0UMoSULtsjd66acXh+zPSw PjizMZPY6Ermp0Hb1wIkgSn4cNDQtEtEPrbAOimN0oEJCJhafRV8T3Owe48NaAS4 eXZxMK610uoVMF3DM6jFvQYW+x6cTQDyFxNRtKfJzfgQbivHFmXJ7aWH8xwtXdEo 2pxsCgWvVgruTi2tP/pyjCGHqwWnx4utgoajS5kvkQEt4UOBEn3iGzPHFTne4Jgg aKWVrQ9wDLkgTJxQbSRC =e2oS -----END PGP SIGNATURE----- --1LKvkjL3sHcu1TtY-- --===============0600148377== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0600148377==--