From: Wei Liu <wei.liu2@citrix.com>
To: Paulina Szubarczyk <paulinaszubarczyk@gmail.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
George.Dunlap@eu.citrix.com,
Dario Faggioli <dario.faggioli@citrix.com>,
xen-devel@lists.xenproject.org, roger.pau@citrix.com
Subject: Re: [PATCH 00/11] Return failure on failure for more xl commands
Date: Wed, 30 Mar 2016 16:14:20 +0100 [thread overview]
Message-ID: <20160330151420.GI5656@citrix.com> (raw)
In-Reply-To: <1459350170-9573-1-git-send-email-paulinaszubarczyk@gmail.com>
On Wed, Mar 30, 2016 at 05:02:39PM +0200, Paulina Szubarczyk wrote:
> This patch includes the changes from a patch prepared by George Dunlap
> [0] and expands them to more xl commands.
>
Hello,
Did you perhaps make a mistake? As far as I can tell some patches were
already applied. Don't worry, we all make mistakes from time to time.
I realise you might be looking at master branch. Please check staging
branch to see if you should drop some of the already patches.
And perhaps can you indicate which patches should we look at in case you
don't want to resend just yet.
Wei.
> This is my bite-sized outreachy project [1][2].
>
> Return failure when the command failed for more xl commands:
> - mem-set
> - cd-insert
> - pci-*
> -- freemem
> -- tmem-*
>
> This makes xl more useful for scripting.
>
> In the case of mem-set, it means first cleaning up
> libxl_set_memory_target() to return useful error codes.
>
> For pci-* functions libxl__create_pci_backend(), libxl__device_pci_destroy_all()
> return error codes instead of always 0.
>
> Changes:
> - Remove block-attach patch
> - Split out removal of spurious getinfolist to a separate patch
> - Try to follow CODING_STYLE more closely:
> - In general, don't initialize rc / r, but use set-and-goto
> - Use 'r' for non-libxl error codes
> - Use EXIT_FAILURE and EXIT_SUCCESS rather than magic constants in main_foo()
> - Use 1 and 0 in internal functions of xl
>
> [0] http://lists.xenproject.org/archives/html/xen-devel/2015-12/msg02246.html
> [1] http://lists.xenproject.org/archives/html/xen-devel/2016-03/msg03031.html
> [2] https://www.mail-archive.com/xen-devel@lists.xen.org/msg62055.html
>
> CC: Wei Liu <wei.liu2@citrix.com>
> CC: Ian Jackson <ian.jackson@eu.citrix.com>
> CC: Dario Faggioli <dario.faggioli@citrix.com>
> CC: Ian Campbell <ian.campbell@citrix.com>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-30 15:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 15:02 [PATCH 00/11] Return failure on failure for more xl commands Paulina Szubarczyk
2016-03-30 15:02 ` [PATCH 01/11] libxl_pci: improve return codes " Paulina Szubarczyk
2016-03-30 15:02 ` [PATCH 02/11] libxl_pci: clean an unused return variable Paulina Szubarczyk
2016-03-30 15:02 ` [PATCH 03/11] libxl_pci: Return error code for more pci-* functions Paulina Szubarczyk
2016-03-30 15:02 ` [PATCH 04/11] xl: improve return code for freemem function Paulina Szubarczyk
2016-03-30 15:02 ` [PATCH 05/11] xl: Make set_memory_target return an error code on failure Paulina Szubarczyk
2016-03-30 15:02 ` [PATCH 06/11] xl: Return an error on failed cd-insert Paulina Szubarczyk
2016-03-30 15:02 ` [PATCH 07/11] xl: Return error codes for pci* commands Paulina Szubarczyk
2016-03-30 15:02 ` [PATCH 08/11] xl: improve main_tmem_* return codes Paulina Szubarczyk
2016-03-30 15:02 ` [PATCH 09/11] libxl: Remove pointless hypercall from libxl_set_memory_target Paulina Szubarczyk
2016-03-30 15:02 ` [PATCH 10/11] libxl: Fix libxl_set_memory_target return value Paulina Szubarczyk
2016-03-30 15:02 ` [PATCH 11/11] libxl: libxl_tmem functions improving coding style Paulina Szubarczyk
2016-03-30 15:14 ` Wei Liu [this message]
2016-03-30 17:19 ` [PATCH 00/11] Return failure on failure for more xl commands Paulina Szubarczyk
2016-03-31 15:06 ` Wei Liu
2016-04-01 9:55 ` Paulina Szubarczyk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160330151420.GI5656@citrix.com \
--to=wei.liu2@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=paulinaszubarczyk@gmail.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.