From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from arroyo.ext.ti.com ([192.94.94.40]:34113 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754116AbcC3PXf (ORCPT ); Wed, 30 Mar 2016 11:23:35 -0400 Date: Wed, 30 Mar 2016 10:23:31 -0500 From: Bin Liu To: Antonio Victor Hilario CC: , Felipe Balbi , Subject: Re: [PATCH 001/001] MUSB MULTIPOINT HIGH SPEED DUAL-ROLE CONTROLLER Fix trivial typo in constant name EP_MODE_AUTOREG_NONE Message-ID: <20160330152201.GA1328@uda0271908> References: <422224C1-027D-4F3B-BC4C-5771D95A3FE0@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <422224C1-027D-4F3B-BC4C-5771D95A3FE0@gmail.com> Sender: stable-owner@vger.kernel.org List-ID: Hi, On Wed, Mar 30, 2016 at 06:56:28AM +0800, Antonio Victor Hilario wrote: > I'd been using kernel 3.18.10-29 on a set of Beaglebone Black boards, and had found and corrected this on my local build tree. > > Kernel build fails when the source file drivers/usb/musb/musb_cppi41.c is built, with these kernel options enabled: > > CONFIG_USB_MUSB_HDRC=y > CONFIG_USB_TI_CPPI41_DMA=y > > The build fails with these errors, due to a misspelled constant name EP_MODE_AUTOREQ_NONE: > > drivers/usb/musb/musb_cppi41.c: In function 'cppi41_dma_channel_abort': > drivers/usb/musb/musb_cppi41.c:544:43: error: 'EP_MODE_AUTOREQ_NONE' undeclared (first use in this function) > cppi41_set_autoreq_mode(cppi41_channel, EP_MODE_AUTOREQ_NONE); > ^ > drivers/usb/musb/musb_cppi41.c:544:43: note: each undeclared identifier is reported only once for each function it appears in > scripts/Makefile.build:257: recipe for target 'drivers/usb/musb/musb_cppi41.o' failed > make[3]: *** [drivers/usb/musb/musb_cppi41.o] Error 1 > scripts/Makefile.build:402: recipe for target 'drivers/usb/musb' failed > make[2]: *** [drivers/usb/musb] Error 2 > scripts/Makefile.build:402: recipe for target 'drivers/usb' failed > make[1]: *** [drivers/usb] Error 2 > Makefile:937: recipe for target 'drivers' failed > This is due to the stable kernel misses patch 0149b07 (usb: musb: cppi41: correct the macro name EP_MODE_AUTOREG_*) from the upstream when back porting. I believe this has been corrected in v3.12, but not sure about other stable kernels - I wasn't cc'd in these backport notification emails. Regards, -Bin.