From: Bin Liu <b-liu@ti.com>
To: Antonio Victor Hilario <avahilario@gmail.com>,
<linux-usb@vger.kernel.org>, Felipe Balbi <balbi@kernel.org>,
<stable@vger.kernel.org>
Subject: Re: [PATCH 001/001] MUSB MULTIPOINT HIGH SPEED DUAL-ROLE CONTROLLER Fix trivial typo in constant name EP_MODE_AUTOREG_NONE
Date: Wed, 30 Mar 2016 10:28:36 -0500 [thread overview]
Message-ID: <20160330152836.GB1328@uda0271908> (raw)
In-Reply-To: <20160330152201.GA1328@uda0271908>
Hi,
On Wed, Mar 30, 2016 at 10:23:31AM -0500, Bin Liu wrote:
> Hi,
>
>
> On Wed, Mar 30, 2016 at 06:56:28AM +0800, Antonio Victor Hilario wrote:
> > I'd been using kernel 3.18.10-29 on a set of Beaglebone Black boards, and had found and corrected this on my local build tree.
> >
> > Kernel build fails when the source file drivers/usb/musb/musb_cppi41.c is built, with these kernel options enabled:
> >
> > CONFIG_USB_MUSB_HDRC=y
> > CONFIG_USB_TI_CPPI41_DMA=y
> >
> > The build fails with these errors, due to a misspelled constant name EP_MODE_AUTOREQ_NONE:
> >
> > drivers/usb/musb/musb_cppi41.c: In function 'cppi41_dma_channel_abort':
> > drivers/usb/musb/musb_cppi41.c:544:43: error: 'EP_MODE_AUTOREQ_NONE' undeclared (first use in this function)
> > cppi41_set_autoreq_mode(cppi41_channel, EP_MODE_AUTOREQ_NONE);
> > ^
> > drivers/usb/musb/musb_cppi41.c:544:43: note: each undeclared identifier is reported only once for each function it appears in
> > scripts/Makefile.build:257: recipe for target 'drivers/usb/musb/musb_cppi41.o' failed
> > make[3]: *** [drivers/usb/musb/musb_cppi41.o] Error 1
> > scripts/Makefile.build:402: recipe for target 'drivers/usb/musb' failed
> > make[2]: *** [drivers/usb/musb] Error 2
> > scripts/Makefile.build:402: recipe for target 'drivers/usb' failed
> > make[1]: *** [drivers/usb] Error 2
> > Makefile:937: recipe for target 'drivers' failed
> >
>
> This is due to the stable kernel misses patch 0149b07 (usb: musb:
> cppi41: correct the macro name EP_MODE_AUTOREG_*) from the upstream when
> back porting.
>
> I believe this has been corrected in v3.12, but not sure about other
> stable kernels - I wasn't cc'd in these backport notification emails.
FYI -
http://article.gmane.org/gmane.linux.kernel.stable/167063/match=cppi41
>
> Regards,
> -Bin.
>
prev parent reply other threads:[~2016-03-30 15:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <422224C1-027D-4F3B-BC4C-5771D95A3FE0@gmail.com>
2016-03-30 15:23 ` [PATCH 001/001] MUSB MULTIPOINT HIGH SPEED DUAL-ROLE CONTROLLER Fix trivial typo in constant name EP_MODE_AUTOREG_NONE Bin Liu
2016-03-30 15:28 ` Bin Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160330152836.GB1328@uda0271908 \
--to=b-liu@ti.com \
--cc=avahilario@gmail.com \
--cc=balbi@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.