All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	DRI Development <dri-devel@lists.freedesktop.org>,
	Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH 03/10] drm/armada: Drop fb gamma_set/get functions
Date: Wed, 30 Mar 2016 17:29:12 +0200	[thread overview]
Message-ID: <20160330152912.GL2510@phenom.ffwll.local> (raw)
In-Reply-To: <20160330125605.GG19428@n2100.arm.linux.org.uk>

On Wed, Mar 30, 2016 at 01:56:06PM +0100, Russell King - ARM Linux wrote:
> On Wed, Mar 30, 2016 at 01:19:21PM +0200, Daniel Vetter wrote:
> > On Wed, Mar 30, 2016 at 1:09 PM, Russell King - ARM Linux
> > <linux@arm.linux.org.uk> wrote:
> > > On Wed, Mar 30, 2016 at 11:51:18AM +0200, Daniel Vetter wrote:
> > >> The fb helper private gamma_set/get functions are only required when
> > >> the driver supports paletted 8bit mode with fbdev. Armada uses 32bpp
> > >> unconditionally, so this is just dead code. It also doesn't do
> > >> anything really. Let's just remove it.
> > >
> > > This comment is misleading: Armada supports 16bpp formats as well as
> > > 32bpp, and the hardware does have 8bpp modes to, but I've chosen not
> > > to support the 8bpp modes.
> > 
> > This is purely about the fbdev emulation (and yeah need to clarify
> > that), not about kms support in general. And these two gamma_set/get
> > hooks are _only_ used by the fbdev emulation, and only needed if you
> > do 8bit paletted mode. Ok if I change the commit message to "Armada
> > used 32bpp unconditionally for fbdev emulation, ..."?
> 
> I still don't know where you get that from - the armada fbdev code
> supports more than just 32bpp.  Please explain.

Ok, I lost myself in the code and missed the cmdline parsing of fbdev
depth. So seems indeed possible to create a 8bit fbdev on armada (since
armada_framebuffer_create won't reject it, and I didn't see anything
else). I'll drop this patch. Thanks for the feedback.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2016-03-30 15:29 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-30  9:51 [PATCH 00/10] legacy gamma code cleanup Daniel Vetter
2016-03-30  9:51 ` [PATCH 01/10] drm: Initialize a linear gamma table by default Daniel Vetter
2016-05-31 13:05   ` Maarten Lankhorst
2016-05-31 13:24     ` Daniel Vetter
2016-05-31 13:30       ` Maarten Lankhorst
2016-03-30  9:51 ` [PATCH 02/10] drm/fb-helper: Remove dead code in setcolreg Daniel Vetter
2016-05-31 13:09   ` Maarten Lankhorst
2016-05-31 13:25     ` Daniel Vetter
2016-03-30  9:51 ` [PATCH 03/10] drm/armada: Drop fb gamma_set/get functions Daniel Vetter
2016-03-30 11:09   ` Russell King - ARM Linux
2016-03-30 11:19     ` Daniel Vetter
2016-03-30 12:56       ` Russell King - ARM Linux
2016-03-30 15:29         ` Daniel Vetter [this message]
2016-03-30  9:51 ` [PATCH 04/10] drm/bochs: Drop fake gamma support Daniel Vetter
2016-04-01  8:37   ` Gerd Hoffmann
2016-03-30  9:51 ` [PATCH 05/10] drm/cirrus: Drop redundnant gamma size check Daniel Vetter
2016-05-31 13:11   ` Maarten Lankhorst
2016-03-30  9:51 ` [PATCH 06/10] drm/msm: Nuke dummy gamma_set/get functions Daniel Vetter
2016-05-31 13:18   ` Maarten Lankhorst
2016-03-30  9:51 ` [PATCH 07/10] drm/virtio: Drop dummy gamma table support Daniel Vetter
2016-04-01  8:38   ` Gerd Hoffmann
2016-04-12 11:14     ` Daniel Vetter
2016-04-12 13:58   ` Emil Velikov
2016-04-12 14:27     ` Julia Lawall
2016-03-30  9:51 ` [PATCH 08/10] drm/imx: Don't set a gamma table size Daniel Vetter
2016-03-30 13:36   ` Philipp Zabel
2016-03-30  9:51 ` [PATCH 09/10] drm/qxl: " Daniel Vetter
2016-05-31 13:17   ` Maarten Lankhorst
2016-05-31 13:27     ` Daniel Vetter
2016-03-30  9:51 ` [PATCH 10/10] drm/tegra: " Daniel Vetter
2016-03-30 12:39   ` Thierry Reding
2016-03-30 15:31     ` Daniel Vetter
2016-03-31 10:33   ` Thierry Reding
2016-03-31  7:15 ` ✗ Fi.CI.BAT: failure for legacy gamma code cleanup Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160330152912.GL2510@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=daniel.vetter@ffwll.ch \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.