From: Sebastian Herbszt <herbszt@gmx.de>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Ewan D. Milne" <emilne@redhat.com>,
Hannes Reinecke <hare@suse.de>,
Christoph Hellwig <hch@infradead.org>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org,
Bart Van Assche <bart.vanassche@sandisk.com>,
Sebastian Herbszt <herbszt@gmx.de>
Subject: Re: [RESEND PATCH v2 2/2] scsi: Add intermediate STARGET_REMOVE state to scsi_target_state
Date: Wed, 30 Mar 2016 23:44:56 +0200 [thread overview]
Message-ID: <20160330234456.00004733@localhost> (raw)
In-Reply-To: <108843b606da2c793bd830af42d5907bf8776d13.1459249252.git.jthumshirn__45300.0338202857$1459322118$gmane$org@suse.de>
Johannes Thumshirn wrote:
> Add intermediate STARGET_REMOVE state to scsi_target_state to avoid running
> into the BUG_ON() in scsi_target_reap().
>
> This intermediate state is only valid in the path from scsi_remove_target() to
> scsi_target_destroy() indicating this target is going to be removed.
>
> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
> Fixes: 40998193560dab6c3ce8d25f4fa58a23e252ef38
> Cc: stable@vger.kernel.org
> Reviewed-by: Hannes Reinecke <hare@suse.com>
> Reviewed-by: Ewan D. Milne <emilne@redhat.com>
> ---
>
> Changes from v1:
> * The state transition from STARGET_CREATED to STARGET_DEL is legitimate,
> so don't BUG() on it. Found by the 0-Day Bot.
This is yet another attempt to fix 40998193560d. Can you please explain how
it is "superior" to the one proposed by Bart before [1] ?
[1] http://marc.info/?l=linux-scsi&m=145227191917602&w=2
Sebastian
next prev parent reply other threads:[~2016-03-30 21:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 7:09 [RESEND PATCH v2 0/2] Update SCSI target removal path Johannes Thumshirn
2016-03-30 7:09 ` [RESEND PATCH v2 1/2] Revert "scsi: fix soft lockup in scsi_remove_target() on module removal" Johannes Thumshirn
2016-03-30 7:09 ` Johannes Thumshirn
2016-03-30 7:09 ` Johannes Thumshirn
2016-03-30 16:23 ` Ewan D. Milne
2016-03-30 7:09 ` [RESEND PATCH v2 2/2] scsi: Add intermediate STARGET_REMOVE state to scsi_target_state Johannes Thumshirn
2016-03-30 21:44 ` Sebastian Herbszt [this message]
2016-03-31 7:24 ` jthumshirn
2016-03-30 7:09 ` Johannes Thumshirn
2016-03-30 7:09 ` Johannes Thumshirn
2016-03-30 16:25 ` Ewan D. Milne
[not found] ` <1459261538.30035.12.camel@localhost.localdomain>
[not found] ` <yq1twjorday.fsf@sermon.lab.mkp.net>
2016-03-30 11:01 ` [PATCH v2 0/2] Update SCSI target removal path jthumshirn
2016-03-30 16:30 ` Ewan D. Milne
2016-03-30 17:09 ` Laurence Oberman
2016-03-30 16:43 ` [RESEND PATCH " James Bottomley
2016-03-31 6:58 ` jthumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160330234456.00004733@localhost \
--to=herbszt@gmx.de \
--cc=bart.vanassche@sandisk.com \
--cc=emilne@redhat.com \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.