From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] boost: fix getchar issue with uClibc and gcc <= 4.8.2
Date: Thu, 31 Mar 2016 03:48:02 +0200 [thread overview]
Message-ID: <20160331034802.4d1d7f1e@free-electrons.com> (raw)
In-Reply-To: <1459376376-18985-1-git-send-email-joerg.krause@embedded.rocks>
Hello,
On Thu, 31 Mar 2016 00:19:36 +0200, J?rg Krause wrote:
> getchar() is defined as a macro in uClibc. This hits gcc bug 58952 [1] for all
> gcc versions <= 4.8.2 and building boost/test fails:
>
> ./boost/test/impl/unit_test_main.ipp: In function 'int boost::unit_test::unit_test_main(boost::unit_test::init_unit_test_func, int, char**)':
> ./boost/test/impl/unit_test_main.ipp:194:18: error: expected unqualified-id before '(' token
>
> To allow building boost/test with uClibc based toolchains with gcc <= 4.8.2 use
> parenthesis for std::getchar.
>
> Fixes:
> http://autobuild.buildroot.net/results/506/506b3b1b4087318a4247456782ac9e4f128d5db6/
> http://autobuild.buildroot.net/results/5f2/5f2a8fb5cb823160542ee721591867b34bd25de6/
> http://autobuild.buildroot.net/results/e3e/e3e6002ac5b40f7f03d32ba9da99f6497f01b42f/
> .. and more
>
> Upstream status: Pending
> https://github.com/boostorg/test/pull/97
>
> [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58952
>
> Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
> ---
> v2:
> - add autobuild fixes
Weird, I remember discussing this issue quite a long time ago, and I
think we had already fixed it. But it looks like not. So thanks for
submitting this patch. Applied!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-03-31 1:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 22:19 [Buildroot] [PATCH v2] boost: fix getchar issue with uClibc and gcc <= 4.8.2 Jörg Krause
2016-03-31 1:48 ` Thomas Petazzoni [this message]
2016-03-31 7:49 ` Jörg Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160331034802.4d1d7f1e@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.