From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 31 Mar 2016 09:09:05 +0200 From: Boris Brezillon To: Stephen Boyd Cc: Thierry Reding , linux-pwm@vger.kernel.org, Mike Turquette , linux-clk@vger.kernel.org, Mark Brown , Liam Girdwood , Kamil Debski , lm-sensors@lm-sensors.org, Jean Delvare , Guenter Roeck , Dmitry Torokhov , linux-input@vger.kernel.org, Bryan Wu , Richard Purdie , Jacek Anaszewski , linux-leds@vger.kernel.org, Maxime Ripard , Chen-Yu Tsai , linux-sunxi@googlegroups.com, Joachim Eastwood , Thomas Petazzoni , Heiko Stuebner , linux-rockchip@lists.infradead.org, Jingoo Han , Lee Jones , linux-fbdev@vger.kernel.org, Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Robert Jarzmik , Alexandre Belloni , Kukjin Kim , Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, Daniel Vetter , Jani Nikula , Jonathan Corbet , linux-doc@vger.kernel.org, David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Hartley Sweeten , Ryan Mallon , Alexander Shiyan , Milo Kim Subject: Re: [PATCH v5 05/46] pwm: introduce the pwm_args concept Message-ID: <20160331090905.05df7b05@bbrezillon> In-Reply-To: <20160330215510.GS18567@codeaurora.org> References: <1459368249-13241-1-git-send-email-boris.brezillon@free-electrons.com> <1459368249-13241-6-git-send-email-boris.brezillon@free-electrons.com> <20160330215510.GS18567@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII List-ID: On Wed, 30 Mar 2016 14:55:10 -0700 Stephen Boyd wrote: > On 03/30, Boris Brezillon wrote: > > @@ -74,6 +74,23 @@ enum pwm_polarity { > > PWM_POLARITY_INVERSED, > > }; > > > > +/** > > + * struct pwm_args - PWM arguments > > + * @period: reference period > > + * @polarity: reference polarity > > + * > > + * This structure describe board-dependent arguments attached to a PWM > > s/describe/describes/ > > > + * device. Those arguments are usually retrieved from the PWM lookup table or > > + * DT definition. > > + * This should not be confused with the PWM state: PWM args not representing > > s/not representing/don't represent/ ? > > > + * the current PWM state, but the configuration the PWM user plan to use > > s/plan/plans/ > > > + * on this PWM device. > > + */ > > +struct pwm_args { > > + unsigned int period; > > + enum pwm_polarity polarity; > > +}; > > + > Will fix these errors. Thanks, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Date: Thu, 31 Mar 2016 07:09:05 +0000 Subject: Re: [PATCH v5 05/46] pwm: introduce the pwm_args concept Message-Id: <20160331090905.05df7b05@bbrezillon> List-Id: References: <1459368249-13241-1-git-send-email-boris.brezillon@free-electrons.com> <1459368249-13241-6-git-send-email-boris.brezillon@free-electrons.com> <20160330215510.GS18567@codeaurora.org> In-Reply-To: <20160330215510.GS18567-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Stephen Boyd Cc: Thierry Reding , linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mike Turquette , linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mark Brown , Liam Girdwood , Kamil Debski , lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org, Jean Delvare , Guenter Roeck , Dmitry Torokhov , linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Bryan Wu , Richard Purdie , Jacek Anaszewski , linux-leds-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Maxime Ripard , Chen-Yu Tsai , linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Joachim Eastwood , Thomas Petazzoni , Heiko Stuebner , linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Jingoo Han , Lee Jones On Wed, 30 Mar 2016 14:55:10 -0700 Stephen Boyd wrote: > On 03/30, Boris Brezillon wrote: > > @@ -74,6 +74,23 @@ enum pwm_polarity { > > PWM_POLARITY_INVERSED, > > }; > > > > +/** > > + * struct pwm_args - PWM arguments > > + * @period: reference period > > + * @polarity: reference polarity > > + * > > + * This structure describe board-dependent arguments attached to a PWM > > s/describe/describes/ > > > + * device. Those arguments are usually retrieved from the PWM lookup table or > > + * DT definition. > > + * This should not be confused with the PWM state: PWM args not representing > > s/not representing/don't represent/ ? > > > + * the current PWM state, but the configuration the PWM user plan to use > > s/plan/plans/ > > > + * on this PWM device. > > + */ > > +struct pwm_args { > > + unsigned int period; > > + enum pwm_polarity polarity; > > +}; > > + > Will fix these errors. Thanks, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH v5 05/46] pwm: introduce the pwm_args concept Date: Thu, 31 Mar 2016 09:09:05 +0200 Message-ID: <20160331090905.05df7b05@bbrezillon> References: <1459368249-13241-1-git-send-email-boris.brezillon@free-electrons.com> <1459368249-13241-6-git-send-email-boris.brezillon@free-electrons.com> <20160330215510.GS18567@codeaurora.org> Reply-To: boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <20160330215510.GS18567-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Stephen Boyd Cc: Thierry Reding , linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mike Turquette , linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mark Brown , Liam Girdwood , Kamil Debski , lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org, Jean Delvare , Guenter Roeck , Dmitry Torokhov , linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Bryan Wu , Richard Purdie , Jacek Anaszewski , linux-leds-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Maxime Ripard , Chen-Yu Tsai , linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Joachim Eastwood , Thomas Petazzoni , Heiko Stuebner , linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Jingoo Han , Lee Jones List-Id: linux-input@vger.kernel.org On Wed, 30 Mar 2016 14:55:10 -0700 Stephen Boyd wrote: > On 03/30, Boris Brezillon wrote: > > @@ -74,6 +74,23 @@ enum pwm_polarity { > > PWM_POLARITY_INVERSED, > > }; > > > > +/** > > + * struct pwm_args - PWM arguments > > + * @period: reference period > > + * @polarity: reference polarity > > + * > > + * This structure describe board-dependent arguments attached to a PWM > > s/describe/describes/ > > > + * device. Those arguments are usually retrieved from the PWM lookup table or > > + * DT definition. > > + * This should not be confused with the PWM state: PWM args not representing > > s/not representing/don't represent/ ? > > > + * the current PWM state, but the configuration the PWM user plan to use > > s/plan/plans/ > > > + * on this PWM device. > > + */ > > +struct pwm_args { > > + unsigned int period; > > + enum pwm_polarity polarity; > > +}; > > + > Will fix these errors. Thanks, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: boris.brezillon@free-electrons.com (Boris Brezillon) Date: Thu, 31 Mar 2016 09:09:05 +0200 Subject: [PATCH v5 05/46] pwm: introduce the pwm_args concept In-Reply-To: <20160330215510.GS18567@codeaurora.org> References: <1459368249-13241-1-git-send-email-boris.brezillon@free-electrons.com> <1459368249-13241-6-git-send-email-boris.brezillon@free-electrons.com> <20160330215510.GS18567@codeaurora.org> Message-ID: <20160331090905.05df7b05@bbrezillon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, 30 Mar 2016 14:55:10 -0700 Stephen Boyd wrote: > On 03/30, Boris Brezillon wrote: > > @@ -74,6 +74,23 @@ enum pwm_polarity { > > PWM_POLARITY_INVERSED, > > }; > > > > +/** > > + * struct pwm_args - PWM arguments > > + * @period: reference period > > + * @polarity: reference polarity > > + * > > + * This structure describe board-dependent arguments attached to a PWM > > s/describe/describes/ > > > + * device. Those arguments are usually retrieved from the PWM lookup table or > > + * DT definition. > > + * This should not be confused with the PWM state: PWM args not representing > > s/not representing/don't represent/ ? > > > + * the current PWM state, but the configuration the PWM user plan to use > > s/plan/plans/ > > > + * on this PWM device. > > + */ > > +struct pwm_args { > > + unsigned int period; > > + enum pwm_polarity polarity; > > +}; > > + > Will fix these errors. Thanks, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com