From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] norm: fix build failure with old headers
Date: Thu, 31 Mar 2016 18:18:48 +0200 [thread overview]
Message-ID: <20160331181848.00984a4f@free-electrons.com> (raw)
In-Reply-To: <1459431938-28257-1-git-send-email-gustavo@zacarias.com.ar>
Hello,
On Thu, 31 Mar 2016 10:45:38 -0300, Gustavo Zacarias wrote:
> The version check for the nfq_get_payload prototype is wrong since it's
> done against linux headers when in fact it changed with the 1.0.0
> release of libnetfilter_queue, leading to build failure in toolchains
> that have old headers when libnetfilter_queue is present. Fixes:
> http://autobuild.buildroot.net/results/c0e/c0e897a6db888d4a7e0302cdc1e0cbec7d1e88f3/
>
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---
> .../0002-protolib-drop-linux-version-check.patch | 38 ++++++++++++++++++++++
> 1 file changed, 38 insertions(+)
> create mode 100644 package/norm/0002-protolib-drop-linux-version-check.patch
Applied to master, thanks. It would be good to submit the patch
upstream. Maybe the patch is not acceptable as-is because it will break
with older versions of libnetfilter_queue, but I guess an autoconf
check can be added for that.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-03-31 16:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 13:45 [Buildroot] [PATCH] norm: fix build failure with old headers Gustavo Zacarias
2016-03-31 16:18 ` Thomas Petazzoni [this message]
2016-03-31 16:23 ` Gustavo Zacarias
2016-03-31 16:30 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160331181848.00984a4f@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.