All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: "Tejun Heo" <tj@kernel.org>,
	"Chris Wilson" <chris@chris-wilson.co.uk>,
	"Daniel Vetter" <daniel.vetter@intel.com>,
	intel-gfx@lists.freedesktop.org,
	"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
	NeilBrown <neilb@suse.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernfs: Move faulting copy_user operations outside of the mutex
Date: Thu, 31 Mar 2016 13:15:20 -0700	[thread overview]
Message-ID: <20160331201520.GA22511@kroah.com> (raw)
In-Reply-To: <1459445405.8191.32.camel@linux.intel.com>

On Thu, Mar 31, 2016 at 08:30:05PM +0300, Joonas Lahtinen wrote:
> On to, 2016-03-31 at 12:49 -0400, Tejun Heo wrote:
> > On Thu, Mar 31, 2016 at 11:45:06AM +0100, Chris Wilson wrote:
> > > 
> > > A fault in a user provided buffer may lead anywhere, and lockdep warns
> > > that we have a potential deadlock between the mm->mmap_sem and the
> > > kernfs file mutex:
> > ...
> > > 
> > > Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94350
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> > > Cc: Tejun Heo <tj@kernel.org>
> > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > Cc: NeilBrown <neilb@suse.de>
> > > Cc: linux-kernel@vger.kernel.org
> > Acked-by: Tejun Heo <tj@kernel.org>
> > 
> 
> Thanks.
> 
> I have applied this locally to our repo to be included into our CI
> builds.
> 
> We will drop the local patch once this waterfalls from upstream to our
> drm-intel-nightly repo.

So is this something that needs to get into 4.6-final because it
resolves a reported issue?  Or can it wait for 4.7-rc1?

thanks,

greg k-h

  reply	other threads:[~2016-03-31 20:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-31 10:45 [PATCH] kernfs: Move faulting copy_user operations outside of the mutex Chris Wilson
2016-03-31 10:45 ` Chris Wilson
2016-03-31 16:49 ` Tejun Heo
2016-03-31 16:49   ` Tejun Heo
2016-03-31 17:30   ` Joonas Lahtinen
2016-03-31 17:30     ` Joonas Lahtinen
2016-03-31 20:15     ` Greg Kroah-Hartman [this message]
2016-04-01  6:11       ` Joonas Lahtinen
2016-04-01  6:11         ` Joonas Lahtinen
  -- strict thread matches above, loose matches on Subject: below --
2016-03-24 14:38 Chris Wilson
2016-03-24 15:01 ` Joonas Lahtinen
2016-02-23 11:40 Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160331201520.GA22511@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=chris@chris-wilson.co.uk \
    --cc=daniel.vetter@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=tj@kernel.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.