From: Wouter Verhelst <w@uter.be>
To: Alex Bligh <alex@alex.org.uk>
Cc: "nbd-general@lists.sourceforge.net"
<nbd-general@lists.sourceforge.net>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [Nbd] [PATCH 2/2] Correct definition of NBD_CMD_FLAG_FUA
Date: Fri, 1 Apr 2016 09:59:33 +0200 [thread overview]
Message-ID: <20160401075933.GA25514@grep.be> (raw)
In-Reply-To: <1459448132-52364-1-git-send-email-alex@alex.org.uk>
On Thu, Mar 31, 2016 at 07:15:32PM +0100, Alex Bligh wrote:
> NBD_CMD_FLAG_FUA is defined as 1<<0 in the documentation, but
> 1<<16 in nbd.h. It is not used anywhere within the code.
Yes it is:
wouter@gangtai:~/code/c/nbd$ grep -rl CMD_FLAG_FUA *
doc/proto.md
make-integrityhuge.c
nbd.h
nbd-server.c
nbd-trdump.c
tests/run/nbd-tester-client.c
wouter@gangtai:~/code/c/nbd$
I don't mind bringing the code in sync with what the documentation says,
but it should not change behaviour ;-)
--
< ron> I mean, the main *practical* problem with C++, is there's like a dozen
people in the world who think they really understand all of its rules,
and pretty much all of them are just lying to themselves too.
-- #debian-devel, OFTC, 2016-02-12
next prev parent reply other threads:[~2016-04-01 8:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 18:15 [Qemu-devel] [PATCH 2/2] Correct definition of NBD_CMD_FLAG_FUA Alex Bligh
2016-03-31 18:21 ` Alex Bligh
2016-03-31 19:14 ` Eric Blake
2016-03-31 19:25 ` Alex Bligh
2016-03-31 20:07 ` Eric Blake
2016-03-31 20:19 ` Alex Bligh
2016-04-01 7:59 ` Wouter Verhelst [this message]
2016-04-01 9:32 ` [Qemu-devel] [Nbd] " Alex Bligh
2016-04-01 9:43 ` Wouter Verhelst
2016-04-01 10:11 ` Alex Bligh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160401075933.GA25514@grep.be \
--to=w@uter.be \
--cc=alex@alex.org.uk \
--cc=nbd-general@lists.sourceforge.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.