From: Stephen Hemminger <stephen@networkplumber.org>
To: Rasesh Mody <rasesh.mody@qlogic.com>
Cc: <thomas.monjalon@6wind.com>, <bruce.richardson@intel.com>,
<dev@dpdk.org>, <ameen.rahman@qlogic.com>,
<harish.patil@qlogic.com>, <sony.chacko@qlogic.com>
Subject: Re: [PATCH v5 05/10] qede: Add core driver
Date: Fri, 1 Apr 2016 08:41:42 -0700 [thread overview]
Message-ID: <20160401084142.11bd9a06@xeon-e3> (raw)
In-Reply-To: <1459476927-21387-6-git-send-email-rasesh.mody@qlogic.com>
On Thu, 31 Mar 2016 19:15:22 -0700
Rasesh Mody <rasesh.mody@qlogic.com> wrote:
> +struct qed_filter_ucast_params {
> + enum qed_filter_xcast_params_type type;
> + uint8_t vlan_valid;
> + uint16_t vlan;
> + uint8_t mac_valid;
> + unsigned char mac[ETHER_ADDR_LEN];
> +} __attribute__ ((__packed__));
Why packed? Why not just rearrange elements to eliminate the padding holes?
next prev parent reply other threads:[~2016-04-01 15:41 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 2:15 [PATCH v5 00/10] qede: Add qede PMD Rasesh Mody
2016-04-01 2:15 ` [PATCH v5 01/10] qede: Add maintainers Rasesh Mody
2016-04-18 16:41 ` Thomas Monjalon
2016-04-18 21:40 ` Harish Patil
2016-04-01 2:15 ` [PATCH v5 02/10] qede: Add documentation Rasesh Mody
2016-04-01 2:15 ` [PATCH v5 03/10] qede: Add license file Rasesh Mody
2016-04-01 2:15 ` [PATCH v5 04/10] qede: Add base driver Rasesh Mody
2016-04-01 2:15 ` [PATCH v5 05/10] qede: Add core driver Rasesh Mody
2016-04-01 15:41 ` Stephen Hemminger [this message]
2016-04-01 15:42 ` Stephen Hemminger
2016-04-19 12:35 ` Thomas Monjalon
2016-04-19 12:59 ` Thomas Monjalon
2016-04-20 1:09 ` Rasesh Mody
2016-04-20 8:54 ` Thomas Monjalon
2016-04-22 10:48 ` Compiler minimum versions. (Was: [PATCH v5 05/10] qede: Add core driver) Bruce Richardson
2016-04-19 13:18 ` [PATCH v5 05/10] qede: Add core driver Thomas Monjalon
2016-04-20 1:10 ` Rasesh Mody
2016-04-01 2:15 ` [PATCH v5 06/10] qede: Add L2 support Rasesh Mody
2016-04-01 2:15 ` [PATCH v5 07/10] qede: Add SRIOV support Rasesh Mody
2016-04-01 2:15 ` [PATCH v5 08/10] qede: Add attention support Rasesh Mody
2016-04-01 2:15 ` [PATCH v5 09/10] qede: Add DCBX support Rasesh Mody
2016-04-19 12:51 ` Thomas Monjalon
2016-04-01 2:15 ` [PATCH v5 10/10] qede: Enable PMD build Rasesh Mody
2016-04-18 15:34 ` Thomas Monjalon
2016-04-20 0:07 ` Harish Patil
2016-04-18 15:37 ` Thomas Monjalon
2016-04-20 0:14 ` Harish Patil
2016-04-20 8:51 ` Thomas Monjalon
2016-04-20 9:25 ` Bruce Richardson
2016-04-20 16:43 ` Harish Patil
2016-04-21 10:01 ` Bruce Richardson
2016-04-20 16:36 ` Harish Patil
2016-04-01 15:44 ` [PATCH v5 00/10] qede: Add qede PMD Stephen Hemminger
2016-04-01 15:51 ` Harish Patil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160401084142.11bd9a06@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=ameen.rahman@qlogic.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=harish.patil@qlogic.com \
--cc=rasesh.mody@qlogic.com \
--cc=sony.chacko@qlogic.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.