Re: [Qemu-devel] [PATCH for-2.6] target-i386: KVM loves Hyper-V!

["Daniel P. Berrange" <berrange@redhat.com>]

On Fri, Apr 01, 2016 at 10:18:02AM +0200, Paolo Bonzini wrote:
> Microsoft loves Linux, and Red Hat loves .NET.  Since we can put whatever
> we want in the Hyper-V vendor signature, let's show some love too!
> 
> Cc: Andreas Färber <afaerber@suse.de>
> Cc: Alex Williamson <alex.williamson@redhat.com>
> Cc: Denis V. Lunev <den@openvz.org>
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> Cc: Roman Kagan <rkagan@virtuozzo.com>
> Cc: KY Srinivasan <kys@microsoft.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  target-i386/kvm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
> index 799fdfa..1968f04 100644
> --- a/target-i386/kvm.c
> +++ b/target-i386/kvm.c
> @@ -592,7 +592,7 @@ int kvm_arch_init_vcpu(CPUState *cs)
>          c = &cpuid_data.entries[cpuid_i++];
>          c->function = HYPERV_CPUID_VENDOR_AND_MAX_FUNCTIONS;
>          if (!cpu->hyperv_vendor_id) {
> -            memcpy(signature, "Microsoft Hv", 12);
> +            memcpy(signature, "KVM<3HyperV!", 12);

I think it'd be nicer to use the unicode heart symbol ♡ encoded as utf-8
eg

  memcpy(signature, "KVM\xe2\x99\xa1HyperV", 12);


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|