All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: "Wangnan (F)" <wangnan0@huawei.com>
Cc: David Ahern <dsahern@gmail.com>, Jiri Olsa <jolsa@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: perf trace + BPF
Date: Fri, 1 Apr 2016 10:50:40 -0300	[thread overview]
Message-ID: <20160401135040.GD7115@kernel.org> (raw)
In-Reply-To: <56FE77D0.50900@huawei.com>

Em Fri, Apr 01, 2016 at 09:29:52PM +0800, Wangnan (F) escreveu:
> 
> 
> On 2016/4/1 2:08, Arnaldo Carvalho de Melo wrote:
> >Hi Wang,
> >
> >	Trying to get back at working with 'perf trace' + BPF and I'm
> >noticing that the perf_event_attr->sample_type for the BPF events are
> >different than the ones for the raw_syscalls:sys_{enter,exit} or to
> >other tracepoint events we may ask 'perf trace' to set up, for instance,
> >for:
> >
> >perf trace -vv -T --ev sched:sched_switch --ev bpf-output/no-inherit,name=evt/ --ev /home/acme/bpf/test_bpf_trace.c/map:channel.event=evt/ usleep 10
> >
> >We get these sample types (full perf_event_attr dump at the end of this
> >message):
> >
> >sched:sched_switch:
> >sample_type                      IP|TID|TIME|CPU|PERIOD|RAW|IDENTIFIER
> >
> >[root@jouet ~]# perf probe -l
> >   perf_bpf_probe:func_begin (on SyS_nanosleep@linux/kernel/time/hrtimer.c)
> >   perf_bpf_probe:func_end (on SyS_nanosleep%return@linux/kernel/time/hrtimer.c)
> >
> >   sample_type                    IP|TID|RAW|IDENTIFIER
> >
> >raw_syscalls:sys_{enter,exit}:
> >
> >   sample_type                    IP|TID|TIME|CPU|PERIOD|RAW|IDENTIFIER
> >
> >I guess this is an interaction with that "no-inherit" part, probably we need to
> >set PERF_SAMPLE_TIME by some other means...
> 
> Please see [1]. Not related to no-inherit, just because the bpf-output event
> is not a tracepoint.

Right, that was a dead end of mine when investigating this, thanks for
fixing this up!
 
> And glad to see you restart working on my patches again!

Yeah, hopefully this time we'll get most of what is outstanding merged.

I want to at some time experiment with doing things 'perf trace' needs
with BPF, behind the scenes :-)
 
> Thank you.
> 
> [1] http://lkml.kernel.org/g/1459517202-42320-1-git-send-email-wangnan0@huawei.com
> 
> 
> 
> >- Arnaldo
> >
> 

      reply	other threads:[~2016-04-01 13:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-31 18:08 perf trace + BPF Arnaldo Carvalho de Melo
2016-04-01 13:29 ` Wangnan (F)
2016-04-01 13:50   ` Arnaldo Carvalho de Melo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160401135040.GD7115@kernel.org \
    --to=acme@kernel.org \
    --cc=dsahern@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung@kernel.org \
    --cc=wangnan0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.