From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 02/16] drm/i915: Make {vlv, chv}_{disable, update}_pll() more similar Date: Fri, 1 Apr 2016 22:59:45 +0300 Message-ID: <20160401195945.GB4329@intel.com> References: <1458052809-23426-1-git-send-email-ville.syrjala@linux.intel.com> <1458052809-23426-3-git-send-email-ville.syrjala@linux.intel.com> <87y490149z.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id AA83C6ED67 for ; Fri, 1 Apr 2016 19:59:48 +0000 (UTC) Content-Disposition: inline In-Reply-To: <87y490149z.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: Deepak M , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBNYXIgMzAsIDIwMTYgYXQgMDQ6MzE6MDRQTSArMDMwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gT24gVHVlLCAxNSBNYXIgMjAxNiwgdmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20g d3JvdGU6Cj4gPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50 ZWwuY29tPgo+ID4KPiA+IFRoZSBWTFYgYW5kIENIViBEUExMIGRpc2FibGUgYW5kIHVwZGF0ZSBh cmUgYWxtb3N0IGlkZW50aWNhbCBpbgo+ID4gaG93IHRoZSBEUExML0RQTExfTUQgcmVnaXN0ZXJz IG5lZWQgdG8gYmUgc2V0IHVwLiBCdXQgdGhlIGNvZGUKPiA+IGxvb2tzIG1vcmUgZGlmZmVyZW50 IHRoYW4gaXQgcmVhbGx5IGlzLiBUcnkgdG8gYnJpbmcgdGhlbSBpbnRvCj4gPiBsaW5lLgo+ID4K PiA+IHYyOiBzL2Nodl91cGRhdGVfcGxsL2Nodl9jb21wdXRlX2RwbGwvCj4gPgo+ID4gU2lnbmVk LW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4K PiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDYzICsr KysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAy NSBpbnNlcnRpb25zKCspLCAzOCBkZWxldGlvbnMoLSkKPiA+Cj4gPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZGlzcGxheS5jCj4gPiBpbmRleCAyMjkzMGYwNTQ1N2MuLjQxNGVkNTAwN2U2MCAxMDA2 NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiBAQCAtMTc1OSwxNiAr MTc1OSwxMyBAQCBzdGF0aWMgdm9pZCB2bHZfZGlzYWJsZV9wbGwoc3RydWN0IGRybV9pOTE1X3By aXZhdGUgKmRldl9wcml2LCBlbnVtIHBpcGUgcGlwZSkKPiA+ICAJLyogTWFrZSBzdXJlIHRoZSBw aXBlIGlzbid0IHN0aWxsIHJlbHlpbmcgb24gdXMgKi8KPiA+ICAJYXNzZXJ0X3BpcGVfZGlzYWJs ZWQoZGV2X3ByaXYsIHBpcGUpOwo+ID4gIAo+ID4gLQkvKgo+ID4gLQkgKiBMZWF2ZSBpbnRlZ3Jh dGVkIGNsb2NrIHNvdXJjZSBhbmQgcmVmZXJlbmNlIGNsb2NrIGVuYWJsZWQgZm9yIHBpcGUgQi4K PiA+IC0JICogVGhlIGxhdHRlciBpcyBuZWVkZWQgZm9yIFZHQSBob3RwbHVnIC8gbWFudWFsIGRl dGVjdGlvbi4KPiA+IC0JICovCj4gCj4gU28sIHlvdSBjaGFuZ2UgdGhpcyB0byBrZWVwIHRoZSBy ZWZlcmVuY2UgY2xvY2sgZW5hYmxlZCBmb3IgYm90aAo+IHBpcGVzLiBEZXNlcnZlcyBhIG1lbnRp b24gaW4gdGhlIGNvbW1pdCBtZXNzYWdlLiBBRkFJQ1QgaXQncyB0aGUgb25seQo+IGZ1bmN0aW9u YWwgY2hhbmdlIGluIHRoZSBwYXRjaC4KCkFkZGVkIHRoZSBmb2xsb3dpbmcgbm90ZSB3aGlsZSBw dXNoaW5nOgoKIk5vdGUgdGhhdCB3ZSBub3cgbGVhdmUgdGhlIHJlZmNsb2NrIGFsd2F5cyBlbmFi bGVkIGZvciBib3RoCiBEUExMcyBpbiB0aGUgZHVhbCBjaGFubmVsIFBIWS4gQnV0IHRoYXQncyBw ZXJmZWN0bHkgZmluZSBzaW5jZQogaXQncyB0aGUgc2FtZSBjbG9jaywgYW5kIHdlIGFueXdheSBh bHJlYWR5IGRvIHRoYXQgd2hlbiB0dXJuaW5nCiB0aGUgZGlzcDJkIHBvd2VyIHdlbGwgb24uIgoK PiAKPiBPdGhlciB0aGFuIHRoYXQsCj4gCj4gUmV2aWV3ZWQtYnk6IEphbmkgTmlrdWxhIDxqYW5p Lm5pa3VsYUBpbnRlbC5jb20+Cj4gCj4gCj4gPiAtCXZhbCA9IERQTExfVkdBX01PREVfRElTOwo+ ID4gLQlpZiAocGlwZSA9PSBQSVBFX0IpCj4gPiAtCQl2YWwgPSBEUExMX0lOVEVHUkFURURfQ1JJ X0NMS19WTFYgfCBEUExMX1JFRl9DTEtfRU5BQkxFX1ZMVjsKPiA+ICsJdmFsID0gRFBMTF9JTlRF R1JBVEVEX1JFRl9DTEtfVkxWIHwKPiA+ICsJCURQTExfUkVGX0NMS19FTkFCTEVfVkxWIHwgRFBM TF9WR0FfTU9ERV9ESVM7Cj4gPiArCWlmIChwaXBlICE9IFBJUEVfQSkKPiA+ICsJCXZhbCB8PSBE UExMX0lOVEVHUkFURURfQ1JJX0NMS19WTFY7Cj4gPiArCj4gPiAgCUk5MTVfV1JJVEUoRFBMTChw aXBlKSwgdmFsKTsKPiA+ICAJUE9TVElOR19SRUFEKERQTEwocGlwZSkpOwo+ID4gLQo+ID4gIH0K PiA+ICAKPiA+ICBzdGF0aWMgdm9pZCBjaHZfZGlzYWJsZV9wbGwoc3RydWN0IGRybV9pOTE1X3By aXZhdGUgKmRldl9wcml2LCBlbnVtIHBpcGUgcGlwZSkKPiA+IEBAIC0xNzc5LDExICsxNzc2LDEx IEBAIHN0YXRpYyB2b2lkIGNodl9kaXNhYmxlX3BsbChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq ZGV2X3ByaXYsIGVudW0gcGlwZSBwaXBlKQo+ID4gIAkvKiBNYWtlIHN1cmUgdGhlIHBpcGUgaXNu J3Qgc3RpbGwgcmVseWluZyBvbiB1cyAqLwo+ID4gIAlhc3NlcnRfcGlwZV9kaXNhYmxlZChkZXZf cHJpdiwgcGlwZSk7Cj4gPiAgCj4gPiAtCS8qIFNldCBQTEwgZW4gPSAwICovCj4gPiAgCXZhbCA9 IERQTExfU1NDX1JFRl9DTEtfQ0hWIHwKPiA+ICAJCURQTExfUkVGX0NMS19FTkFCTEVfVkxWIHwg RFBMTF9WR0FfTU9ERV9ESVM7Cj4gPiAgCWlmIChwaXBlICE9IFBJUEVfQSkKPiA+ICAJCXZhbCB8 PSBEUExMX0lOVEVHUkFURURfQ1JJX0NMS19WTFY7Cj4gPiArCj4gPiAgCUk5MTVfV1JJVEUoRFBM TChwaXBlKSwgdmFsKTsKPiA+ICAJUE9TVElOR19SRUFEKERQTEwocGlwZSkpOwo+ID4gIAo+ID4g QEAgLTcyNDAsMjQgKzcyMzcsMjcgQEAgdm9pZCBpbnRlbF9kcF9zZXRfbV9uKHN0cnVjdCBpbnRl bF9jcnRjICpjcnRjLCBlbnVtIGxpbmtfbV9uX3NldCBtX24pCj4gPiAgc3RhdGljIHZvaWQgdmx2 X2NvbXB1dGVfZHBsbChzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YywKPiA+ICAJCQkgICAgIHN0cnVj dCBpbnRlbF9jcnRjX3N0YXRlICpwaXBlX2NvbmZpZykKPiA+ICB7Cj4gPiAtCXUzMiBkcGxsLCBk cGxsX21kOwo+ID4gKwlwaXBlX2NvbmZpZy0+ZHBsbF9od19zdGF0ZS5kcGxsID0gRFBMTF9JTlRF R1JBVEVEX1JFRl9DTEtfVkxWIHwKPiA+ICsJCURQTExfUkVGX0NMS19FTkFCTEVfVkxWIHwgRFBM TF9WR0FfTU9ERV9ESVMgfAo+ID4gKwkJRFBMTF9WQ09fRU5BQkxFIHwgRFBMTF9FWFRfQlVGRkVS X0VOQUJMRV9WTFY7Cj4gPiArCWlmIChjcnRjLT5waXBlICE9IFBJUEVfQSkKPiA+ICsJCXBpcGVf Y29uZmlnLT5kcGxsX2h3X3N0YXRlLmRwbGwgfD0gRFBMTF9JTlRFR1JBVEVEX0NSSV9DTEtfVkxW Owo+ID4gIAo+ID4gLQkvKgo+ID4gLQkgKiBFbmFibGUgRFBJTyBjbG9jayBpbnB1dC4gV2Ugc2hv dWxkIG5ldmVyIGRpc2FibGUgdGhlIHJlZmVyZW5jZQo+ID4gLQkgKiBjbG9jayBmb3IgcGlwZSBC LCBzaW5jZSBWR0EgaG90cGx1ZyAvIG1hbnVhbCBkZXRlY3Rpb24gZGVwZW5kcwo+ID4gLQkgKiBv biBpdC4KPiA+IC0JICovCj4gPiAtCWRwbGwgPSBEUExMX0VYVF9CVUZGRVJfRU5BQkxFX1ZMViB8 IERQTExfUkVGX0NMS19FTkFCTEVfVkxWIHwKPiA+IC0JCURQTExfVkdBX01PREVfRElTIHwgRFBM TF9JTlRFR1JBVEVEX1JFRl9DTEtfVkxWOwo+ID4gLQkvKiBXZSBzaG91bGQgbmV2ZXIgZGlzYWJs ZSB0aGlzLCBzZXQgaXQgaGVyZSBmb3Igc3RhdGUgdHJhY2tpbmcgKi8KPiA+IC0JaWYgKGNydGMt PnBpcGUgPT0gUElQRV9CKQo+ID4gLQkJZHBsbCB8PSBEUExMX0lOVEVHUkFURURfQ1JJX0NMS19W TFY7Cj4gPiAtCWRwbGwgfD0gRFBMTF9WQ09fRU5BQkxFOwo+ID4gLQlwaXBlX2NvbmZpZy0+ZHBs bF9od19zdGF0ZS5kcGxsID0gZHBsbDsKPiA+ICsJcGlwZV9jb25maWctPmRwbGxfaHdfc3RhdGUu ZHBsbF9tZCA9Cj4gPiArCQkocGlwZV9jb25maWctPnBpeGVsX211bHRpcGxpZXIgLSAxKSA8PCBE UExMX01EX1VESV9NVUxUSVBMSUVSX1NISUZUOwo+ID4gK30KPiA+ICsKPiA+ICtzdGF0aWMgdm9p ZCBjaHZfY29tcHV0ZV9kcGxsKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLAo+ID4gKwkJCSAgICAg c3RydWN0IGludGVsX2NydGNfc3RhdGUgKnBpcGVfY29uZmlnKQo+ID4gK3sKPiA+ICsJcGlwZV9j b25maWctPmRwbGxfaHdfc3RhdGUuZHBsbCA9IERQTExfU1NDX1JFRl9DTEtfQ0hWIHwKPiA+ICsJ CURQTExfUkVGX0NMS19FTkFCTEVfVkxWIHwgRFBMTF9WR0FfTU9ERV9ESVMgfAo+ID4gKwkJRFBM TF9WQ09fRU5BQkxFOwo+ID4gKwlpZiAoY3J0Yy0+cGlwZSAhPSBQSVBFX0EpCj4gPiArCQlwaXBl X2NvbmZpZy0+ZHBsbF9od19zdGF0ZS5kcGxsIHw9IERQTExfSU5URUdSQVRFRF9DUklfQ0xLX1ZM VjsKPiA+ICAKPiA+IC0JZHBsbF9tZCA9IChwaXBlX2NvbmZpZy0+cGl4ZWxfbXVsdGlwbGllciAt IDEpCj4gPiAtCQk8PCBEUExMX01EX1VESV9NVUxUSVBMSUVSX1NISUZUOwo+ID4gLQlwaXBlX2Nv bmZpZy0+ZHBsbF9od19zdGF0ZS5kcGxsX21kID0gZHBsbF9tZDsKPiA+ICsJcGlwZV9jb25maWct PmRwbGxfaHdfc3RhdGUuZHBsbF9tZCA9Cj4gPiArCQkocGlwZV9jb25maWctPnBpeGVsX211bHRp cGxpZXIgLSAxKSA8PCBEUExMX01EX1VESV9NVUxUSVBMSUVSX1NISUZUOwo+ID4gIH0KPiA+ICAK PiA+ICBzdGF0aWMgdm9pZCB2bHZfcHJlcGFyZV9wbGwoc3RydWN0IGludGVsX2NydGMgKmNydGMs Cj4gPiBAQCAtNzM1MSwxOSArNzM1MSw2IEBAIHN0YXRpYyB2b2lkIHZsdl9wcmVwYXJlX3BsbChz dHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YywKPiA+ICAJbXV0ZXhfdW5sb2NrKCZkZXZfcHJpdi0+c2Jf bG9jayk7Cj4gPiAgfQo+ID4gIAo+ID4gLXN0YXRpYyB2b2lkIGNodl9jb21wdXRlX2RwbGwoc3Ry dWN0IGludGVsX2NydGMgKmNydGMsCj4gPiAtCQkJICAgICBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0 ZSAqcGlwZV9jb25maWcpCj4gPiAtewo+ID4gLQlwaXBlX2NvbmZpZy0+ZHBsbF9od19zdGF0ZS5k cGxsID0gRFBMTF9TU0NfUkVGX0NMS19DSFYgfAo+ID4gLQkJRFBMTF9SRUZfQ0xLX0VOQUJMRV9W TFYgfCBEUExMX1ZHQV9NT0RFX0RJUyB8Cj4gPiAtCQlEUExMX1ZDT19FTkFCTEU7Cj4gPiAtCWlm IChjcnRjLT5waXBlICE9IFBJUEVfQSkKPiA+IC0JCXBpcGVfY29uZmlnLT5kcGxsX2h3X3N0YXRl LmRwbGwgfD0gRFBMTF9JTlRFR1JBVEVEX0NSSV9DTEtfVkxWOwo+ID4gLQo+ID4gLQlwaXBlX2Nv bmZpZy0+ZHBsbF9od19zdGF0ZS5kcGxsX21kID0KPiA+IC0JCShwaXBlX2NvbmZpZy0+cGl4ZWxf bXVsdGlwbGllciAtIDEpIDw8IERQTExfTURfVURJX01VTFRJUExJRVJfU0hJRlQ7Cj4gPiAtfQo+ ID4gLQo+ID4gIHN0YXRpYyB2b2lkIGNodl9wcmVwYXJlX3BsbChzdHJ1Y3QgaW50ZWxfY3J0YyAq Y3J0YywKPiA+ICAJCQkgICAgY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKnBpcGVfY29u ZmlnKQo+ID4gIHsKPiAKPiAtLSAKPiBKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgVGVj aG5vbG9neSBDZW50ZXIKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxp c3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=