Re: [PATCH v2] xfs_quota: add missed options -D and -P into man page

From: "Bill O'Donnell" <billodo@redhat.com>
To: Zorro Lang <zlang@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v2] xfs_quota: add missed options -D and -P into man page
Date: Sat, 2 Apr 2016 07:37:55 -0500	[thread overview]
Message-ID: <20160402123754.GA4269@redhat.com> (raw)
In-Reply-To: <1459565110-23923-1-git-send-email-zlang@redhat.com>

On Sat, Apr 02, 2016 at 10:45:10AM +0800, Zorro Lang wrote:
> There're two options in xfsprogs/quota/init.c:init() function, the -D
> option is used to set a file to instead of /etc/projects, and the -P
> option is used to set a file to instead of /etc/projid. I don't know
> these two options when I write xfstests case xfs/133, because
> there's no any information about them in xfs_quota and other related
> man pages. I learn about these two options by read others test cases.
> 
> So I add these options into xfs_quota man page.
> 
> Reported-by: Eryu Guan <eguan@redhat.com>
> Signed-off-by: Zorro Lang <zlang@redhat.com>
> ---

Reviewed-by: Bill O'Donnell <billodo@redhat.com>

> 
> Hi,
> 
> V2 patch fix some english words problems:
> Point a file contain the -> Specify a file containing the
> directories trees -> directory trees
> 
> Thanks for Bill specify my english syntax errors. English is not my
> mother tongue, sorry for the mistake when I write english.
> 
> Thanks,
> Zorro
> 
>  man/man8/xfs_quota.8 | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/man/man8/xfs_quota.8 b/man/man8/xfs_quota.8
> index 951252b..ab67423 100644
> --- a/man/man8/xfs_quota.8
> +++ b/man/man8/xfs_quota.8
> @@ -15,6 +15,12 @@ xfs_quota \- manage use of quota on XFS filesystems
>  .B \-d
>  .I project
>  ] ... [
> +.B \-D
> +.I projects_file
> +] [
> +.B \-P
> +.I projid_file
> +] [
>  .IR path " ... ]"
>  .br
>  .B xfs_quota \-V
> @@ -53,6 +59,18 @@ commands to the set of projects specified. Multiple
>  .B \-d
>  arguments may be given.
>  .TP
> +.BI \-D " projects_file"
> +Specify a file containing the mapping of numeric project identifiers
> +to directory trees.
> +.I /etc/projects
> +as default, if this option is none.
> +.TP
> +.BI \-P " projid_file"
> +Specify a file containing the mapping of numeric project identifiers
> +to project names.
> +.I /etc/projid
> +as default, if this option is none.
> +.TP
>  .B \-V
>  Prints the version number and exits.
>  .PP
> -- 
> 2.5.0
> 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs