From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] wilc1000-firmware: new package
Date: Sat, 2 Apr 2016 17:20:58 +0200 [thread overview]
Message-ID: <20160402172058.77e5cba2@free-electrons.com> (raw)
In-Reply-To: <1459491576-32280-1-git-send-email-ludovic.desroches@atmel.com>
Hello,
On Fri, 1 Apr 2016 08:19:36 +0200, Ludovic Desroches wrote:
> Firmware for Atmel Wilc1000 wireless device.
>
> Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
> ---
> package/Config.in | 1 +
> package/wilc1000-firmware/Config.in | 6 ++++++
> package/wilc1000-firmware/wilc1000-firmware.mk | 25 +++++++++++++++++++++++++
A hash file was missing.
> +WILC1000_FIRMWARE_VERSION = 14.1
> +WILC1000_FIRMWARE_SITE = https://github.com/linux4sc/wireless-firmware/archive
> +WILC1000_FIRMWARE_SOURCE = v$(WILC1000_FIRMWARE_VERSION)_Firmware.zip
What a crappy file name, which doesn't even contain the name of the
project :-/
> +WILC1000_FIRMWARE_DRIVER_FILE = wilc1003_firmware.bin
This variable is not really needed, it's only used once
> +WILC1000_FIRMWARE_LICENSE = PROPRIETARY
> +
> +define WILC1000_FIRMWARE_EXTRACT_CMDS
> + $(UNZIP) -d $(BUILD_DIR) $(DL_DIR)/$(WILC1000_FIRMWARE_SOURCE)
> + mv $(BUILD_DIR)/wireless-firmware-$(WILC1000_FIRMWARE_VERSION)_Firmware/* $(@D)
> + rmdir $(BUILD_DIR)/wireless-firmware-$(WILC1000_FIRMWARE_VERSION)_Firmware
> +endef
> +
> +define WILC1000_FIRMWARE_INSTALL_TARGET_CMDS
> + $(INSTALL) -d -m 0755 $(TARGET_DIR)/lib/firmware/atmel/
> + cp $(@D)/$(WILC1000_FIRMWARE_DRIVER_FILE) $(TARGET_DIR)/lib/firmware/atmel/
I've simplified this to use just one $(INSTALL) -D -m 0644 invocation,
which is sufficient since 1/ there is only one file to install and 2/
option -D tells $(INSTALL) to create sub-directories as necessary.
Applied with those fixes. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-04-02 15:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 6:19 [Buildroot] [PATCH] wilc1000-firmware: new package Ludovic Desroches
2016-04-01 6:22 ` Baruch Siach
2016-04-01 7:16 ` Ludovic Desroches
2016-04-02 15:20 ` Thomas Petazzoni [this message]
2016-04-04 6:01 ` Ludovic Desroches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160402172058.77e5cba2@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.