All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: mohammed.billoo@gmail.com
Cc: johnny.kim@atmel.com, austin.shin@atmel.com,
	chris.park@atmel.com, tony.cho@atmel.com, glen.lee@atmel.com,
	leo.kim@atmel.com, linux-wireless@vger.kernel.org,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Ensure that comments adhere to coding standard
Date: Sun, 3 Apr 2016 11:41:23 -0700	[thread overview]
Message-ID: <20160403184123.GA12414@kroah.com> (raw)
In-Reply-To: <1459707526-21124-1-git-send-email-mohammed.billoo@gmail.com>

On Sun, Apr 03, 2016 at 02:18:46PM -0400, mohammed.billoo@gmail.com wrote:
> From: Mohammed Billoo <mohammed.billoo@gmail.com>
> 
> Files in wilc1000 were modified to ensure that comments
> adhere to standard specified by Documentation/CodingStyle
> 
> Signed-off-by: Mohammed Billoo <mohammed.billoo@gmail.com>

Please put the subsystem and driver in your subject: as we have no idea
what this is referring to otherwise.  Look at the other patches that
have been accepted for this driver to see examples of how to do that by
running:
	git log drivers/staging/wilc1000

Also, note that this is a network driver, so the comments here are
already in the correct format, so I don't think this patch is needed at
all, do you?

thanks,

greg k-h

  reply	other threads:[~2016-04-03 18:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-03 18:18 [PATCH] Ensure that comments adhere to coding standard mohammed.billoo
2016-04-03 18:41 ` Greg KH [this message]
2016-04-03 18:45 ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160403184123.GA12414@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=austin.shin@atmel.com \
    --cc=chris.park@atmel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=glen.lee@atmel.com \
    --cc=johnny.kim@atmel.com \
    --cc=leo.kim@atmel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mohammed.billoo@gmail.com \
    --cc=tony.cho@atmel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.