From: Ralf Baechle <ralf@linux-mips.org>
To: Binbin Zhou <zhoubb@lemote.com>
Cc: John Crispin <john@phrozen.org>,
"Steven J . Hill" <Steven.Hill@imgtec.com>,
linux-mips@linux-mips.org, Fuxin Zhang <zhangfx@lemote.com>,
Zhangjin Wu <wuzhangjin@gmail.com>,
Kelvin Cheung <keguang.zhang@gmail.com>,
Chunbo Cui <cuicb@lemote.com>, Huacai Chen <chenhc@lemote.com>
Subject: Re: [PATCH v3 2/8] MIPS: Loongson: Add Loongson-1A Kconfig options
Date: Mon, 4 Apr 2016 08:43:49 +0200 [thread overview]
Message-ID: <20160404064349.GA13706@linux-mips.org> (raw)
In-Reply-To: <1456793296-17120-3-git-send-email-zhoubb@lemote.com>
On Tue, Mar 01, 2016 at 08:48:10AM +0800, Binbin Zhou wrote:
> diff --git a/arch/mips/loongson32/Kconfig b/arch/mips/loongson32/Kconfig
> index 7704f20..741867c 100644
> --- a/arch/mips/loongson32/Kconfig
> +++ b/arch/mips/loongson32/Kconfig
> @@ -1,8 +1,28 @@
> if MACH_LOONGSON32
>
> +config ZONE_DMA
> + prompt "Zone DMA"
> + bool
> +
There is already a ZONE_DMA option in arch/mips/Kconfig. Do you really
need ZONE_DMA? Even if so I suggest to not present this option to the
user interactively but enable it with a select - normal users building
a kernel will probably not know what ZONE_DMA is.
Ralf
next prev parent reply other threads:[~2016-04-04 6:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 0:48 [PATCH v3 0/8] MIPS: Loongson: Add the Loongson-1A processor support Binbin Zhou
2016-03-01 0:48 ` [PATCH v3 1/8] MIPS: Loongson: Add basic Loongson-1A CPU support Binbin Zhou
2016-03-01 0:48 ` [PATCH v3 2/8] MIPS: Loongson: Add Loongson-1A Kconfig options Binbin Zhou
2016-04-04 6:43 ` Ralf Baechle [this message]
2016-03-01 0:48 ` [PATCH v3 3/8] MIPS: Loongson: Add platform devices for Loongson-1A/1B Binbin Zhou
2016-04-04 6:51 ` Ralf Baechle
2016-03-01 0:48 ` [PATCH v3 4/8] MIPS: Loongson: Add loongson-1A board support Binbin Zhou
2016-03-01 0:48 ` [PATCH v3 5/8] MIPS: Loongson-1A: Workaround for pll register can't be read Binbin Zhou
2016-04-04 7:29 ` Ralf Baechle
2016-04-22 23:14 ` Stephen Boyd
2016-03-01 0:48 ` [PATCH v3 6/8] MIPS: Loongson-1A: Add IRQ type setting support Binbin Zhou
2016-04-04 7:15 ` Ralf Baechle
2016-03-01 0:48 ` [PATCH v3 7/8] MIPS: Loongson-1A: Enable SPARSEMEN and HIGHMEM Binbin Zhou
2016-03-01 0:48 ` [PATCH v3 8/8] MIPS: Loongson: Add a Loongson-1A default config file Binbin Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160404064349.GA13706@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=Steven.Hill@imgtec.com \
--cc=chenhc@lemote.com \
--cc=cuicb@lemote.com \
--cc=john@phrozen.org \
--cc=keguang.zhang@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=wuzhangjin@gmail.com \
--cc=zhangfx@lemote.com \
--cc=zhoubb@lemote.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.