From: Trevor Woerner <twoerner@gmail.com>
To: Gary Thomas <gary@mlbassoc.com>
Cc: yocto@yoctoproject.org
Subject: Re: [PATCH][meta-raspberrypi 1/2] raspberrypi3: serial console
Date: Mon, 4 Apr 2016 08:02:38 -0700 [thread overview]
Message-ID: <20160404150238.GA29635@linux-mkz6> (raw)
In-Reply-To: <57027B09.2090808@mlbassoc.com>
On Mon 2016-04-04 @ 04:32:41 PM, Gary Thomas wrote:
> On 04/04/2016 03:24 PM, Trevor Woerner wrote:
> >The serial console on the Raspberry Pi 3 is located at /dev/ttyS0 and not
> >/dev/ttyAMA0.
> >
> >Signed-off-by: Trevor Woerner <twoerner@gmail.com>
> >---
> > conf/machine/raspberrypi3.conf | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> >diff --git a/conf/machine/raspberrypi3.conf b/conf/machine/raspberrypi3.conf
> >index 1b73f2f..2c3df41 100644
> >--- a/conf/machine/raspberrypi3.conf
> >+++ b/conf/machine/raspberrypi3.conf
> >@@ -7,3 +7,5 @@ MACHINEOVERRIDES = "raspberrypi2:${MACHINE}"
> > MACHINE_EXTRA_RRECOMMENDS += "linux-firmware-brcm43430"
> >
> > include conf/machine/raspberrypi2.conf
> >+
> >+SERIAL_CONSOLE_raspberrypi3 = "115200 ttyS0"
> >
>
> Why the _raspberrypi3 modifier? Wouldn't SERIAL_CONSOLE = "115200 ttyS0" do?
...because the raspi3 MACHINE just basically includes/requires the raspi2
MACHINE, and the raspi2 MACHINE includes/requires include/rpi-base.inc, and
it's in rpi-base.inc that we find the SERIAL_CONSOLE definition.
Originally I had pulled out the SERIAL_CONSOLE from rpi-base and added it to
each of the raspi MACHINES, 3 of which were the same (AMA0) and one was ttyS0.
Then, looking over the patch set, I thought it would be cleaner to just keep
everything as it was and only add the ttyS0 to the raspi3 MACHINE (which
requires the override).
>
> --
> ------------------------------------------------------------
> Gary Thomas | Consulting for the
> MLB Associates | Embedded world
> ------------------------------------------------------------
> --
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto
next prev parent reply other threads:[~2016-04-04 15:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 13:24 [PATCH][meta-raspberrypi 1/2] raspberrypi3: serial console Trevor Woerner
2016-04-04 13:24 ` [PATCH][meta-raspberrypi 2/2] raspberrypi3: set core frequency Trevor Woerner
2016-04-04 14:32 ` [PATCH][meta-raspberrypi 1/2] raspberrypi3: serial console Gary Thomas
2016-04-04 15:02 ` Trevor Woerner [this message]
2016-04-04 15:06 ` Trevor Woerner
2016-04-04 15:18 ` Trevor Woerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160404150238.GA29635@linux-mkz6 \
--to=twoerner@gmail.com \
--cc=gary@mlbassoc.com \
--cc=yocto@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.