All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Luca Abeni <luca.abeni@unitn.it>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
	Juri Lelli <juri.lelli@arm.com>
Subject: Re: [RFC v2 1/7] Track the active utilisation
Date: Tue, 5 Apr 2016 14:23:27 +0200	[thread overview]
Message-ID: <20160405122327.GU3430@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1459523553-29089-2-git-send-email-luca.abeni@unitn.it>

On Fri, Apr 01, 2016 at 05:12:27PM +0200, Luca Abeni wrote:
> @@ -1210,6 +1232,8 @@ static void task_fork_dl(struct task_struct *p)
>  static void task_dead_dl(struct task_struct *p)
>  {
>  	struct dl_bw *dl_b = dl_bw_of(task_cpu(p));
> +	struct dl_rq *dl_rq = dl_rq_of_se(&p->dl);
> +	struct rq *rq = rq_of_dl_rq(dl_rq);
>  
>  	/*
>  	 * Since we are TASK_DEAD we won't slip out of the domain!
> @@ -1218,6 +1242,9 @@ static void task_dead_dl(struct task_struct *p)
>  	/* XXX we should retain the bw until 0-lag */
>  	dl_b->total_bw -= p->dl.dl_bw;
>  	raw_spin_unlock_irq(&dl_b->lock);
> +
> +	if (task_on_rq_queued(p))
> +		sub_running_bw(&p->dl, &rq->dl);
>  }
>  

A dead task cannot be running, not be queued, right? ISTR you remove
this hunk in a later patch as well.

  reply	other threads:[~2016-04-05 12:23 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-01 15:12 [RFC v2 0/7] CPU reclaiming for SCHED_DEADLINE Luca Abeni
2016-04-01 15:12 ` [RFC v2 1/7] Track the active utilisation Luca Abeni
2016-04-05 12:23   ` Peter Zijlstra [this message]
2016-04-05 16:47     ` luca abeni
2016-04-01 15:12 ` [RFC v2 2/7] Correctly track the active utilisation for migrating tasks Luca Abeni
2016-04-05 12:24   ` Peter Zijlstra
2016-04-05 16:50     ` luca abeni
2016-04-01 15:12 ` [RFC v2 3/7] Improve the tracking of active utilisation Luca Abeni
2016-04-05 12:42   ` Peter Zijlstra
2016-04-05 17:00     ` luca abeni
2016-04-05 12:42   ` Peter Zijlstra
2016-04-05 17:05     ` luca abeni
2016-04-05 14:48   ` Peter Zijlstra
2016-04-05 17:17     ` luca abeni
2016-04-05 15:00   ` Peter Zijlstra
2016-04-05 17:56     ` luca abeni
2016-04-05 18:00       ` Peter Zijlstra
2016-04-05 19:35         ` luca abeni
2016-04-05 18:02       ` Peter Zijlstra
2016-04-05 19:24         ` luca abeni
2016-04-05 19:31           ` Peter Zijlstra
2016-04-05 19:32           ` luca abeni
2016-04-05 18:11       ` Peter Zijlstra
2016-04-01 15:12 ` [RFC v2 4/7] Fix the update of the total -deadline utilization Luca Abeni
2016-04-05 12:58   ` Peter Zijlstra
2016-04-05 17:16     ` luca abeni
2016-04-01 15:12 ` [RFC v2 5/7] GRUB accounting Luca Abeni
2016-04-01 15:12 ` [RFC v2 6/7] Make GRUB a task's flag Luca Abeni
2016-04-01 15:12 ` [RFC v2 7/7] Do not reclaim the whole CPU bandwidth Luca Abeni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160405122327.GU3430@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=juri.lelli@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca.abeni@unitn.it \
    --cc=mingo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.