All of lore.kernel.org
 help / color / mirror / Atom feed
From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH] NVMe: Re-introduce polling for completions
Date: Tue, 5 Apr 2016 05:35:23 -0700	[thread overview]
Message-ID: <20160405123523.GA19495@infradead.org> (raw)
In-Reply-To: <1459808689-7689-1-git-send-email-keith.busch@intel.com>

On Mon, Apr 04, 2016@04:24:49PM -0600, Keith Busch wrote:
> Multiple users have reported device initialization failure on some
> platforms due the driver not receiving expected interrupts. This is not
> the fault of any particular controller. This patch polls for completions
> on the admin queue in the watchdog timer, and starts the timer immediately
> after controller initialization completes, just before the first admin
> command is issued.

So how do any other PCIe device work given that almost no driver does
unconditionaly polling?

> +	spin_lock_irq(&admin_q->q_lock);
> +	nvme_process_cq(admin_q);
> +	spin_unlock_irq(&admin_q->q_lock);

Add a comment on why this is done.  Given that only the admin queue
is polled it's going to be a really convoluted explanation which should
be spelled out in detail.

  parent reply	other threads:[~2016-04-05 12:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-04 22:24 [PATCH] NVMe: Re-introduce polling for completions Keith Busch
2016-04-05  7:32 ` Johannes Thumshirn
2016-04-05 12:35 ` Christoph Hellwig [this message]
2016-04-05 17:54   ` Keith Busch
2016-04-05 21:39     ` Keith Busch
2016-04-05 22:04       ` Judy Brock-SSI
2016-04-05 22:29         ` Keith Busch
2016-04-06  5:22           ` Judy Brock-SSI
2016-04-06  6:56         ` Christoph Hellwig
2016-04-06  6:56       ` Christoph Hellwig
2016-04-12 19:00       ` Christoph Hellwig
2016-04-12 19:02         ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160405123523.GA19495@infradead.org \
    --to=hch@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.