From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53248) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anY8J-00043K-41 for qemu-devel@nongnu.org; Tue, 05 Apr 2016 17:03:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1anY8E-0003bt-V3 for qemu-devel@nongnu.org; Tue, 05 Apr 2016 17:03:31 -0400 Received: from barbershop.grep.be ([89.106.240.122]:43742) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anY8E-0003bb-Ph for qemu-devel@nongnu.org; Tue, 05 Apr 2016 17:03:26 -0400 Date: Tue, 5 Apr 2016 23:03:17 +0200 From: Wouter Verhelst Message-ID: <20160405210317.GE13913@grep.be> References: <1459888946-27233-1-git-send-email-alex@alex.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1459888946-27233-1-git-send-email-alex@alex.org.uk> Subject: Re: [Qemu-devel] [Nbd] [PATCHv2] Amend NBD_OPT_SELECT (now NBD_OPT_INFO) and NBD_OPT_GO documentation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Bligh Cc: "nbd-general@lists.sourceforge.net" , "qemu-devel@nongnu.org" On Tue, Apr 05, 2016 at 09:42:26PM +0100, Alex Bligh wrote: > Amend the NBD_OPT_SELECT and NBD_OPT_GO documentation as > follows: > > * Change NBD_OPT_SELECT to be called NBD_OPT_INFO > > * Remove the 'selection' aspect of that command, so that > it now merely returns information. This is to avoid > the server storing state. > > * Allow a name to be specified on NBD_OPT_GO > > * Make clear the rules for default device selection > > * Remove the provision concerning TLS resetting device selection > > * Remove NBD_REP_ERR_INVALID as a reply to NBD_OPT_GO as there > is now no necessity for a prior NBD_OPT_INFO > > * Make it clear NBD_OPT_GO is in effect a better alternative > for NBD_OPT_EXPORT_NAME > > * Make it clear the NBD_OPT_INFO and NBD_OPT_GO are in > essence the same command, save that NBD_OPT_GO puts you > into transmission mode if successful. > > * Clarify permitted option returns outside TLS to prevent > export enumeration. > > * Remove 'length' 32 bit quantity from > NBD_OPT_SELECT (and don't copy it into NBD_OPT_GO) so it > looks exactly like NBD_OPT_EXPORT_NAME bar the reply. > This length is unnecessary as it's in the option header > anyway. > > * Reorder the fields of an NBD_OPT_INFO / NBD_OPT_GO reply > so the variable length elements are at the end. > > * Make the documentation much more concise. > > Signed-off-by: Alex Bligh [...] applied, thanks. -- < ron> I mean, the main *practical* problem with C++, is there's like a dozen people in the world who think they really understand all of its rules, and pretty much all of them are just lying to themselves too. -- #debian-devel, OFTC, 2016-02-12