From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 5873B7CA4 for ; Wed, 6 Apr 2016 07:51:56 -0500 (CDT) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay1.corp.sgi.com (Postfix) with ESMTP id 1F8108F8035 for ; Wed, 6 Apr 2016 05:51:53 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id 8HwrkaTRNsP8D2OX (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Wed, 06 Apr 2016 05:51:52 -0700 (PDT) Date: Wed, 6 Apr 2016 08:51:50 -0400 From: Brian Foster Subject: Re: [PATCH 2/5] xfs: skip stale inodes in xfs_iflush_cluster Message-ID: <20160406125150.GB4188@bfoster.bfoster> References: <1459934574-25543-1-git-send-email-david@fromorbit.com> <1459934574-25543-3-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1459934574-25543-3-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On Wed, Apr 06, 2016 at 07:22:51PM +1000, Dave Chinner wrote: > From: Dave Chinner > > We don't write back stale inodes, so we should skip them in > xfS_iflush_cluster, too. xfs_iflush_cluster > > Signed-off-by: Dave Chinner > --- Reviewed-by: Brian Foster > fs/xfs/xfs_inode.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c > index 2718d10..6598104 100644 > --- a/fs/xfs/xfs_inode.c > +++ b/fs/xfs/xfs_inode.c > @@ -3190,10 +3190,11 @@ xfs_iflush_cluster( > * because this is an RCU protected lookup, we could find a > * recently freed or even reallocated inode during the lookup. > * We need to check under the i_flags_lock for a valid inode > - * here. Skip it if it is not valid or the wrong inode. > + * here. Skip it if it is not valid, stale or the wrong inode. > */ > spin_lock(&cip->i_flags_lock); > if (!cip->i_ino || > + __xfs_iflags_test(ip, XFS_ISTALE) || > (XFS_INO_TO_AGINO(mp, cip->i_ino) & mask) != first_index) { > spin_unlock(&cip->i_flags_lock); > continue; > -- > 2.7.0 > > _______________________________________________ > xfs mailing list > xfs@oss.sgi.com > http://oss.sgi.com/mailman/listinfo/xfs _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs