All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: peterz@infradead.org, jolsa@kernel.org,
	linux-kernel@vger.kernel.org, mingo@kernel.org,
	Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 11/11] perf, tools, stat: Add extra output of counter values with -v
Date: Wed, 6 Apr 2016 11:32:20 -0300	[thread overview]
Message-ID: <20160406143220.GD5945@kernel.org> (raw)
In-Reply-To: <1459802514-31501-12-git-send-email-andi@firstfloor.org>

Em Mon, Apr 04, 2016 at 01:41:54PM -0700, Andi Kleen escreveu:
> From: Andi Kleen <ak@linux.intel.com>
> 
> Add debug output of raw counter values per CPU when
> perf stat -v is specified, together with their cpu numbers.
> This is very useful to debug problems with per core counters,
> where we can normally only see aggregated values.

Can we do it only when per CPU is in place?

[acme@jouet linux]$ perf stat -v usleep 1
task-clock: 0: 1426718 1426718 1426718
task-clock: 1426718 1426718 1426718
context-switches: 0: 3 1426718 1426718
context-switches: 3 1426718 1426718
cpu-migrations: 0: 1 1426718 1426718
cpu-migrations: 1 1426718 1426718
page-faults: 0: 52 1426718 1426718
page-faults: 52 1426718 1426718
cycles: 0: 4338775 1437628 1437628
cycles: 4338775 1437628 1437628
instructions: 0: 754838 1437628 1437628
instructions: 754838 1437628 1437628
branches: 0: 146638 1437628 1437628
branches: 146638 1437628 1437628
branch-misses: 0: 7871 1437628 1437628
branch-misses: 7871 1437628 1437628

 Performance counter stats for 'usleep 1':

          1.426718      task-clock (msec)         #    0.370 CPUs utilized          
                 3      context-switches          #    0.002 M/sec                  
                 1      cpu-migrations            #    0.701 K/sec                  
                52      page-faults               #    0.036 M/sec                  
         4,338,775      cycles                    #    3.041 GHz                    
           754,838      instructions              #    0.17  insn per cycle         
           146,638      branches                  #  102.780 M/sec                  
             7,871      branch-misses             #    5.37% of all branches        

       0.003859416 seconds time elapsed

[acme@jouet linux]$
 
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> ---
>  tools/perf/builtin-stat.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
> index 6d8ce72cd8c1..0ee224b80056 100644
> --- a/tools/perf/builtin-stat.c
> +++ b/tools/perf/builtin-stat.c
> @@ -314,6 +314,14 @@ static int read_counter(struct perf_evsel *counter)
>  					return -1;
>  				}
>  			}
> +
> +			if (verbose) {
> +				fprintf(stat_config.output,
> +					"%s: %d: %" PRIu64 " %" PRIu64 " %" PRIu64 "\n",
> +						perf_evsel__name(counter),
> +						cpu,
> +						count->val, count->ena, count->run);
> +			}
>  		}
>  	}
>  
> -- 
> 2.5.5

  reply	other threads:[~2016-04-06 14:32 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-04 20:41 Add top down metrics to perf stat Andi Kleen
2016-04-04 20:41 ` [PATCH 01/11] x86, perf: Support sysfs files depending on SMT status Andi Kleen
2016-04-04 20:41 ` [PATCH 02/11] x86, perf: Add Top Down events to Intel Core Andi Kleen
2016-04-04 20:41 ` [PATCH 03/11] x86, perf: Add Top Down events to Intel Atom Andi Kleen
2016-04-04 20:41 ` [PATCH 04/11] x86, perf: Use new ht_on flag in HT leak workaround Andi Kleen
2016-04-04 20:41 ` [PATCH 05/11] perf, tools: Parse an .aggr-per-core event attribute Andi Kleen
2016-04-04 20:41 ` [PATCH 06/11] perf, tools, stat: Force --per-core mode for .aggr-per-core aliases Andi Kleen
2016-04-04 20:41 ` [PATCH 07/11] perf, tools, stat: Avoid fractional digits for integer scales Andi Kleen
2016-04-04 20:41 ` [PATCH 08/11] perf, tools, stat: Scale values by unit before metrics Andi Kleen
2016-04-04 20:41 ` [PATCH 09/11] perf, tools, stat: Basic support for TopDown in perf stat Andi Kleen
2016-04-04 20:41 ` [PATCH 10/11] perf, tools, stat: Add computation of TopDown formulas Andi Kleen
2016-04-04 20:41 ` [PATCH 11/11] perf, tools, stat: Add extra output of counter values with -v Andi Kleen
2016-04-06 14:32   ` Arnaldo Carvalho de Melo [this message]
2016-04-06 15:10     ` Andi Kleen
2016-04-06 15:14       ` Arnaldo Carvalho de Melo
  -- strict thread matches above, loose matches on Subject: below --
2016-03-22 23:08 Add top down metrics to perf stat Andi Kleen
2016-03-22 23:08 ` [PATCH 11/11] perf, tools, stat: Add extra output of counter values with -v Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160406143220.GD5945@kernel.org \
    --to=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.