From: Peter Zijlstra <peterz@infradead.org>
To: Xunlei Pang <xlpang@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Juri Lelli <juri.lelli@arm.com>, Ingo Molnar <mingo@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH v2 2/2] rtmutex: Kill pi_waiters_leftmost from task_struct
Date: Wed, 6 Apr 2016 20:15:29 +0200 [thread overview]
Message-ID: <20160406181529.GU3448@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1459947556-12332-2-git-send-email-xlpang@redhat.com>
On Wed, Apr 06, 2016 at 08:59:16PM +0800, Xunlei Pang wrote:
> Current code use pi_waiters_leftmost to record the leftmost waiter,
> but actually it can be get directly from task_struct::pi_waiters
> using rb_first(). The performance penalty introduced by rb_first()
> should be fine, because normally there aren't that many rtmutexes
> chained together for one task.
>
> We don't remove rt_mutex:pi_waiters_leftmost, as it is quite possible
> for many tasks sharing one rtmutex.
>
> Thus, hereby remove pi_waiters_leftmost from task_struct.
Again, I would like Thomas to chime in. This isn't about usual, but very
much about worst case performance -- its RT code after all.
next prev parent reply other threads:[~2016-04-06 18:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 12:59 [PATCH v2 1/2] sched/rtmutex/deadline: Fix a PI crash for deadline tasks Xunlei Pang
2016-04-06 12:59 ` [PATCH v2 2/2] rtmutex: Kill pi_waiters_leftmost from task_struct Xunlei Pang
2016-04-06 18:15 ` Peter Zijlstra [this message]
2016-04-06 18:14 ` [PATCH v2 1/2] sched/rtmutex/deadline: Fix a PI crash for deadline tasks Peter Zijlstra
2016-04-08 8:04 ` Xunlei Pang
2016-04-08 8:31 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160406181529.GU3448@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=juri.lelli@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=xlpang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.