From: Dan Carpenter <dan.carpenter@oracle.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] fm10k: use ethtool_rxfh_indir_default for default redirection table
Date: Wed, 6 Apr 2016 21:37:03 +0300 [thread overview]
Message-ID: <20160406183703.GA27407@mwanda> (raw)
Hello Jacob Keller,
The patch 0ea7fae44094: "fm10k: use ethtool_rxfh_indir_default for
default redirection table" from Feb 16, 2016, leads to the following
static checker warning:
drivers/net/ethernet/intel/fm10k/fm10k_main.c:1977 fm10k_init_reta()
error: potential null dereference 'indir'. (kcalloc returns null)
drivers/net/ethernet/intel/fm10k/fm10k_main.c
1970
1971 repopulate_reta:
1972 indir = kcalloc(fm10k_get_reta_size(netdev),
1973 sizeof(indir[0]), GFP_KERNEL);
1974
1975 /* generate redirection table using the default kernel policy */
1976 for (i = 0; i < fm10k_get_reta_size(netdev); i++)
1977 indir[i] = ethtool_rxfh_indir_default(i, rss_i);
1978
1979 fm10k_write_reta(interface, indir);
1980
1981 kfree(indir);
1982 }
regards,
dan carpenter
next reply other threads:[~2016-04-06 18:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 18:37 Dan Carpenter [this message]
2016-04-06 21:57 ` [Intel-wired-lan] fm10k: use ethtool_rxfh_indir_default for default redirection table Keller, Jacob E
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160406183703.GA27407@mwanda \
--to=dan.carpenter@oracle.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.