From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Dave Gerlach <d-gerlach@ti.com>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
"Rafael J . Wysocki" <rjw@rjwysocki.net>
Subject: Re: [PATCH] cpuidle: Indicate when a device has been unregistered
Date: Wed, 6 Apr 2016 12:00:48 -0700 [thread overview]
Message-ID: <20160406190047.GA32535@linaro.org> (raw)
In-Reply-To: <1459883138-21136-1-git-send-email-d-gerlach@ti.com>
On Tue, Apr 05, 2016 at 02:05:38PM -0500, Dave Gerlach wrote:
> Currently the 'registered' member of the cpuidle_device struct is set
> to 1 during cpuidle_register_device. In this same function there are
> checks to see if the device is already registered to prevent duplicate
> calls to register the device, but this value is never set to 0 even on
> unregister of the device. Because of this, any attempt to call
> cpuidle_register_device after a call to cpuidle_unregister_device will
> fail which shouldn't be the case.
>
> To prevent this, set registered to 0 when the device is unregistered.
>
> Fixes: c878a52d3c7c ("cpuidle: Check if device is already registered")
> Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
> ---
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
next prev parent reply other threads:[~2016-04-06 19:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-05 19:05 [PATCH] cpuidle: Indicate when a device has been unregistered Dave Gerlach
2016-04-05 19:05 ` Dave Gerlach
2016-04-06 19:00 ` Daniel Lezcano [this message]
2016-04-22 0:40 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160406190047.GA32535@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=d-gerlach@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.