From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 1/2] mfd: max77693: Allow building as a module Date: Thu, 7 Apr 2016 14:29:47 +0100 Message-ID: <20160407132947.GB3323@x1> References: <1459756459-22061-1-git-send-email-k.kozlowski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-wm0-f41.google.com ([74.125.82.41]:35447 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750993AbcDGN3w (ORCPT ); Thu, 7 Apr 2016 09:29:52 -0400 Received: by mail-wm0-f41.google.com with SMTP id 191so91828092wmq.0 for ; Thu, 07 Apr 2016 06:29:51 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1459756459-22061-1-git-send-email-k.kozlowski@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Krzysztof Kozlowski Cc: Chanwoo Choi , Arnd Bergmann , Javier Martinez Canillas , Kukjin Kim , Olof Johansson , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Kevin Hilman , Paul Gortmaker On Mon, 04 Apr 2016, Krzysztof Kozlowski wrote: > The consumer of max77693 regulators on Trats2 board (samsung-usb2-phy > driver) supports deferred probing so the max77693 main MFD driver can= be > built now as a module. This gives more flexibility and removes manual > ordering of init calls. >=20 > Suggested-by: Paul Gortmaker > Cc: Paul Gortmaker > Signed-off-by: Krzysztof Kozlowski > --- > drivers/mfd/Kconfig | 4 ++-- > drivers/mfd/max77693.c | 14 ++------------ > 2 files changed, 4 insertions(+), 14 deletions(-) I assume this can be taken immediately and doesn't depend on anything external to the set? =46or my own reference: Acked-by: Lee Jones > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index eea61e349e26..aa1e7c3f82ee 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -543,8 +543,8 @@ config MFD_MAX77686 > of the device. > =20 > config MFD_MAX77693 > - bool "Maxim Semiconductor MAX77693 PMIC Support" > - depends on I2C=3Dy > + tristate "Maxim Semiconductor MAX77693 PMIC Support" > + depends on I2C > select MFD_CORE > select REGMAP_I2C > select REGMAP_IRQ > diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c > index b83b7a7da1ae..78e501feb96c 100644 > --- a/drivers/mfd/max77693.c > +++ b/drivers/mfd/max77693.c > @@ -368,6 +368,7 @@ static const struct of_device_id max77693_dt_matc= h[] =3D { > { .compatible =3D "maxim,max77693" }, > {}, > }; > +MODULE_DEVICE_TABLE(of, max77693_dt_match); > #endif > =20 > static struct i2c_driver max77693_i2c_driver =3D { > @@ -381,18 +382,7 @@ static struct i2c_driver max77693_i2c_driver =3D= { > .id_table =3D max77693_i2c_id, > }; > =20 > -static int __init max77693_i2c_init(void) > -{ > - return i2c_add_driver(&max77693_i2c_driver); > -} > -/* init early so consumer devices can complete system boot */ > -subsys_initcall(max77693_i2c_init); > - > -static void __exit max77693_i2c_exit(void) > -{ > - i2c_del_driver(&max77693_i2c_driver); > -} > -module_exit(max77693_i2c_exit); > +module_i2c_driver(max77693_i2c_driver); > =20 > MODULE_DESCRIPTION("MAXIM 77693 multi-function core driver"); > MODULE_AUTHOR("SangYoung, Son "); --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Thu, 7 Apr 2016 14:29:47 +0100 Subject: [PATCH 1/2] mfd: max77693: Allow building as a module In-Reply-To: <1459756459-22061-1-git-send-email-k.kozlowski@samsung.com> References: <1459756459-22061-1-git-send-email-k.kozlowski@samsung.com> Message-ID: <20160407132947.GB3323@x1> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, 04 Apr 2016, Krzysztof Kozlowski wrote: > The consumer of max77693 regulators on Trats2 board (samsung-usb2-phy > driver) supports deferred probing so the max77693 main MFD driver can be > built now as a module. This gives more flexibility and removes manual > ordering of init calls. > > Suggested-by: Paul Gortmaker > Cc: Paul Gortmaker > Signed-off-by: Krzysztof Kozlowski > --- > drivers/mfd/Kconfig | 4 ++-- > drivers/mfd/max77693.c | 14 ++------------ > 2 files changed, 4 insertions(+), 14 deletions(-) I assume this can be taken immediately and doesn't depend on anything external to the set? For my own reference: Acked-by: Lee Jones > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index eea61e349e26..aa1e7c3f82ee 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -543,8 +543,8 @@ config MFD_MAX77686 > of the device. > > config MFD_MAX77693 > - bool "Maxim Semiconductor MAX77693 PMIC Support" > - depends on I2C=y > + tristate "Maxim Semiconductor MAX77693 PMIC Support" > + depends on I2C > select MFD_CORE > select REGMAP_I2C > select REGMAP_IRQ > diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c > index b83b7a7da1ae..78e501feb96c 100644 > --- a/drivers/mfd/max77693.c > +++ b/drivers/mfd/max77693.c > @@ -368,6 +368,7 @@ static const struct of_device_id max77693_dt_match[] = { > { .compatible = "maxim,max77693" }, > {}, > }; > +MODULE_DEVICE_TABLE(of, max77693_dt_match); > #endif > > static struct i2c_driver max77693_i2c_driver = { > @@ -381,18 +382,7 @@ static struct i2c_driver max77693_i2c_driver = { > .id_table = max77693_i2c_id, > }; > > -static int __init max77693_i2c_init(void) > -{ > - return i2c_add_driver(&max77693_i2c_driver); > -} > -/* init early so consumer devices can complete system boot */ > -subsys_initcall(max77693_i2c_init); > - > -static void __exit max77693_i2c_exit(void) > -{ > - i2c_del_driver(&max77693_i2c_driver); > -} > -module_exit(max77693_i2c_exit); > +module_i2c_driver(max77693_i2c_driver); > > MODULE_DESCRIPTION("MAXIM 77693 multi-function core driver"); > MODULE_AUTHOR("SangYoung, Son "); -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog