From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756563AbcDGOrJ (ORCPT ); Thu, 7 Apr 2016 10:47:09 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:60964 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755419AbcDGOrH (ORCPT ); Thu, 7 Apr 2016 10:47:07 -0400 Date: Thu, 7 Apr 2016 07:47:05 -0700 From: Greg KH To: Oliver Neukum Cc: Gabriele Mazzotta , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: Oops in 4.6-rc2: NULL pointer dereference in cdc-acm Message-ID: <20160407144705.GE10853@kroah.com> References: <5705762E.4040206@gmail.com> <1460012378.17679.1.camel@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1460012378.17679.1.camel@suse.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 07, 2016 at 08:59:38AM +0200, Oliver Neukum wrote: > On Wed, 2016-04-06 at 22:48 +0200, Gabriele Mazzotta wrote: > > Hi, > > > > I'm getting a kernel oops when I plug some smartphone via USB to my > > laptop, which is currently running the v4.6-rc2. > > > > The problem seems to be caused by a81cf9799ad7 ("cdc-acm: implement > > put_char() and flush_chars()"). > > > > A simple NULL pointer check prevents the crash, but since I have no > > use of cdc-acm and I didn't read the code, I don't know if some other > > changes are required. > > > > Here below you can find the change I did to prevent the crash and > > the dmesg showing the problem. > > Hi, > > thank you for reporting this. You are the second one to report it. > I send a fix upstream last week. > Greg, can we merge this for the next rc? People are hitting this > bug. Yes, will be sent this week, sorry for the delay. greg k-h