All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] cpuset: change default cpuset mount value
Date: Thu, 7 Apr 2016 17:31:05 +0200	[thread overview]
Message-ID: <20160407153105.GA8287@rei.suse.cz> (raw)
In-Reply-To: <57062A03.70705@linux.vnet.ibm.com>

Hi!
> diff --git a/testcases/kernel/controllers/cpuset/cpuset_funcs.sh 
> b/testcases/kernel/controllers/cpuset/cpuset_funcs.sh
> index cd7000e..4c5a17b 100755
> --- a/testcases/kernel/controllers/cpuset/cpuset_funcs.sh
> +++ b/testcases/kernel/controllers/cpuset/cpuset_funcs.sh
> @@ -35,7 +35,7 @@ fi
>   N_NODES=${N_NODES#*-*}
>   N_NODES=$(($N_NODES + 1))
> 
> -CPUSET="/dev/cpuset"
> +CPUSET="/sys/fs/cgroup/cpuset"
>   CPUSET_TMP="/tmp/cpuset_tmp"

This does not seem like a good solution for two reasons. The first is
that LTP should be backward compatible with older distributions and the
second is that the testcase umounts and removes the directory at the end
of the test which will break the system since the /sys/fs/cgroup/cpuset
directory is mounted (and possibly used) by default on newer
distributions.

So the test should be changed to:

* Create and mount cpuset on older distros

* Make use of allready moutned cpuset on newer distros

The cgroup_fj/cgroup_fj_common.sh was allready fixed to work this way.

-- 
Cyril Hrubis
chrubis@suse.cz

      reply	other threads:[~2016-04-07 15:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-07  9:36 [LTP] [PATCH] cpuset: change default cpuset mount value Basavaraju
2016-04-07 15:31 ` Cyril Hrubis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160407153105.GA8287@rei.suse.cz \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.