From mboxrd@z Thu Jan 1 00:00:00 1970 From: marc.zyngier@arm.com (Marc Zyngier) Date: Fri, 8 Apr 2016 09:09:35 +0100 Subject: [PATCH] irqchip/mbigen: Display message of MBIGEN domain created In-Reply-To: <1460099762-51497-1-git-send-email-wangkefeng.wang@huawei.com> References: <1460099762-51497-1-git-send-email-wangkefeng.wang@huawei.com> Message-ID: <20160408090935.4ec95aa8@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, 8 Apr 2016 15:16:02 +0800 Kefeng Wang wrote: > Add message of MBIGEN domain created, it's useful for check > which MBIGEN domain is created. > > Meanwhile, drop module owner, it will be set by driver core. > > Signed-off-by: Kefeng Wang > --- > drivers/irqchip/irq-mbigen.c | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/drivers/irqchip/irq-mbigen.c b/drivers/irqchip/irq-mbigen.c > index d67baa2..a4dc7a0 100644 > --- a/drivers/irqchip/irq-mbigen.c > +++ b/drivers/irqchip/irq-mbigen.c > @@ -257,14 +257,19 @@ static int mbigen_device_probe(struct platform_device *pdev) > if (IS_ERR(mgn_chip->base)) > return PTR_ERR(mgn_chip->base); > > + dev_info(&pdev->dev, "%s\n", pdev->dev.of_node->full_name); > + How is that a useful information? > for_each_child_of_node(pdev->dev.of_node, np) { > if (!of_property_read_bool(np, "interrupt-controller")) > continue; > > parent = platform_bus_type.dev_root; > child = of_platform_device_create(np, NULL, parent); > - if (IS_ERR(child)) > + if (IS_ERR(child)) { > + dev_err(&pdev->dev, "failed to create for %s\n", Failed to create what? > + np->full_name); > return PTR_ERR(child); > + } > > if (of_property_read_u32(child->dev.of_node, "num-pins", > &num_pins) < 0) { > @@ -276,8 +281,13 @@ static int mbigen_device_probe(struct platform_device *pdev) > mbigen_write_msg, > &mbigen_domain_ops, > mgn_chip); > - if (!domain) > + if (!domain) { > + dev_info(&pdev->dev, "unable to create %s domain\n", > + np->full_name); And what about failure to read num_pin? No need for a debug print in this case? > return -ENOMEM; > + } > + > + dev_info(&pdev->dev, "%s domain created\n", np->full_name); > } > > platform_set_drvdata(pdev, mgn_chip); > @@ -293,7 +303,6 @@ MODULE_DEVICE_TABLE(of, mbigen_of_match); > static struct platform_driver mbigen_platform_driver = { > .driver = { > .name = "Hisilicon MBIGEN-V2", > - .owner = THIS_MODULE, > .of_match_table = mbigen_of_match, > }, > .probe = mbigen_device_probe, Overall, this doesn't look like a critical patch to me. I think Ma Jun is working on separate series reworking the way the mgigen is getting probed, so I'd advise you to work with him in order to integrate this patch in his series, as it would make a lot more sense. Thanks, M. -- Jazz is not dead. It just smells funny. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757497AbcDHIJr (ORCPT ); Fri, 8 Apr 2016 04:09:47 -0400 Received: from foss.arm.com ([217.140.101.70]:38255 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750920AbcDHIJo (ORCPT ); Fri, 8 Apr 2016 04:09:44 -0400 Date: Fri, 8 Apr 2016 09:09:35 +0100 From: Marc Zyngier To: Kefeng Wang Cc: Jason Cooper , , , , Subject: Re: [PATCH] irqchip/mbigen: Display message of MBIGEN domain created Message-ID: <20160408090935.4ec95aa8@arm.com> In-Reply-To: <1460099762-51497-1-git-send-email-wangkefeng.wang@huawei.com> References: <1460099762-51497-1-git-send-email-wangkefeng.wang@huawei.com> Organization: ARM Ltd X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 8 Apr 2016 15:16:02 +0800 Kefeng Wang wrote: > Add message of MBIGEN domain created, it's useful for check > which MBIGEN domain is created. > > Meanwhile, drop module owner, it will be set by driver core. > > Signed-off-by: Kefeng Wang > --- > drivers/irqchip/irq-mbigen.c | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/drivers/irqchip/irq-mbigen.c b/drivers/irqchip/irq-mbigen.c > index d67baa2..a4dc7a0 100644 > --- a/drivers/irqchip/irq-mbigen.c > +++ b/drivers/irqchip/irq-mbigen.c > @@ -257,14 +257,19 @@ static int mbigen_device_probe(struct platform_device *pdev) > if (IS_ERR(mgn_chip->base)) > return PTR_ERR(mgn_chip->base); > > + dev_info(&pdev->dev, "%s\n", pdev->dev.of_node->full_name); > + How is that a useful information? > for_each_child_of_node(pdev->dev.of_node, np) { > if (!of_property_read_bool(np, "interrupt-controller")) > continue; > > parent = platform_bus_type.dev_root; > child = of_platform_device_create(np, NULL, parent); > - if (IS_ERR(child)) > + if (IS_ERR(child)) { > + dev_err(&pdev->dev, "failed to create for %s\n", Failed to create what? > + np->full_name); > return PTR_ERR(child); > + } > > if (of_property_read_u32(child->dev.of_node, "num-pins", > &num_pins) < 0) { > @@ -276,8 +281,13 @@ static int mbigen_device_probe(struct platform_device *pdev) > mbigen_write_msg, > &mbigen_domain_ops, > mgn_chip); > - if (!domain) > + if (!domain) { > + dev_info(&pdev->dev, "unable to create %s domain\n", > + np->full_name); And what about failure to read num_pin? No need for a debug print in this case? > return -ENOMEM; > + } > + > + dev_info(&pdev->dev, "%s domain created\n", np->full_name); > } > > platform_set_drvdata(pdev, mgn_chip); > @@ -293,7 +303,6 @@ MODULE_DEVICE_TABLE(of, mbigen_of_match); > static struct platform_driver mbigen_platform_driver = { > .driver = { > .name = "Hisilicon MBIGEN-V2", > - .owner = THIS_MODULE, > .of_match_table = mbigen_of_match, > }, > .probe = mbigen_device_probe, Overall, this doesn't look like a critical patch to me. I think Ma Jun is working on separate series reworking the way the mgigen is getting probed, so I'd advise you to work with him in order to integrate this patch in his series, as it would make a lot more sense. Thanks, M. -- Jazz is not dead. It just smells funny.