Re: [PATCH] conntrack-tools: Fix build for old automake.

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Fri, Apr 08, 2016 at 08:40:01AM +0200, Mart Frauenlob wrote:
> On 07.04.2016 19:53, Mart Frauenlob wrote:
> >On 07.04.2016 19:50, Pablo Neira Ayuso wrote:
> >>On Thu, Apr 07, 2016 at 07:33:43PM +0200, Mart Frauenlob wrote:
> >>>On 07.04.2016 18:47, Pablo Neira Ayuso wrote:
> >>>>On Mon, Apr 04, 2016 at 11:39:40AM +0200, Mart Frauenlob wrote:
> >>>>>  autoreconf fails with automake version smaller than 1.12,
> >>>>>  because of undefined macro AM_PROG_AR.
> >>>>>  So only expand it if it's actually defined.
> >>>>>
> >>>>>Signed-off-by: Mart Frauenlob <mart.frauenlob@chello.at>
> >>>>>---
> >>>>>  configure.ac |    2 +-
> >>>>>  1 files changed, 1 insertions(+), 1 deletions(-)
> >>>>>
> >>>>>diff --git a/configure.ac b/configure.ac
> >>>>>index c541034..2c5913f 100644
> >>>>>--- a/configure.ac
> >>>>>+++ b/configure.ac
> >>>>>@@ -14,7 +14,7 @@ AC_SUBST([libdl_LIBS])
> >>>>>
> >>>>>  AC_PROG_CC
> >>>>>  AC_DISABLE_STATIC
> >>>>>-AM_PROG_AR
> >>>>>+m4_ifdef([AM_PROG_AR], [AM_PROG_AR]) dnl Workaround for Automake 1.11
> >>>>
> >>>>How old is your old system? is it still a distro maintained version?
> >>>
> >>>cat /etc/debian_version
> >>>6.0.10
> >>>Has automake 1.11.
> >>
> >>Is that still maintained?
> >>
> >
> >Quoting https://www.debian.org/News/2016/20160212 :
> >
> >February 12th, 2016
> >The Debian Long Term Support (LTS) Team hereby announces that Debian 6.0
> >("squeeze") support will reach its end-of-life on February 29, 2016,
> >five years after its initial release on February 6, 2011.
> >
> >Hm, no longer since 2 months....
> 
> What does that macro actually do in configure?
> 
> AM_PROG_AR([act-if-fail])
> 
>     You must use this macro when you use the archiver in your project, if
> you want support for unusual archivers such as Microsoft lib. The content of
> the optional argument is executed if the archiver interface is not
> recognized; the default action is to abort configure with an error message.
> 
> Does this archiver get called at all?

eed61ed5        (Felix Janda    2015-05-16 11:19:02 +0200 17)AM_PROG_AR

commit eed61ed57fd2a82b81af9bd2f6895b3aa5221f49
Author: Felix Janda <felix.janda@posteo.de>
Date:   Sat May 16 11:19:02 2015 +0200

    configure: Add AM_PROG_AR to silence automake warning
    
    /usr/share/automake-1.13/am/ltlibrary.am: warning: 'ct_helper_tns.la': linking libtool libraries using a non-POSIX
    /usr/share/automake-1.13/am/ltlibrary.am: archiver requires 'AM_PROG_AR' in 'configure.ac'
    src/helpers/Makefile.am:3:   while processing Libtool library 'ct_helper_tns.la'