From: Wolfram Sang <wsa@the-dreams.de>
To: Axel Lin <axel.lin@ingics.com>
Cc: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH] i2c: jz4780: Return error if clk_freq is set to 0
Date: Fri, 8 Apr 2016 11:55:08 +0200 [thread overview]
Message-ID: <20160408095508.GA1389@katana> (raw)
In-Reply-To: <1460102372.5233.1.camel@ingics.com>
[-- Attachment #1: Type: text/plain, Size: 489 bytes --]
On Fri, Apr 08, 2016 at 03:59:32PM +0800, Axel Lin wrote:
> Current code returns 0 in probe if clk_freq is set to 0.
> As a result, the probe success but the module does not work. Fix it.
>
> Fixes: 34cf2acdafaa ("i2c: jz4780: prevent potential division by zero")
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
True, thanks for the pointer! However, I think we should also check
i2c->speed directly. I'll send a patch right now. Please let me know if
you agree on that one.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-04-08 9:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-08 7:59 [PATCH] i2c: jz4780: Return error if clk_freq is set to 0 Axel Lin
2016-04-08 9:55 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160408095508.GA1389@katana \
--to=wsa@the-dreams.de \
--cc=Zubair.Kakakhel@imgtec.com \
--cc=axel.lin@ingics.com \
--cc=linux-i2c@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.