From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36890) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aoTGo-0000xY-Co for qemu-devel@nongnu.org; Fri, 08 Apr 2016 06:04:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aoTGk-0002Yc-Da for qemu-devel@nongnu.org; Fri, 08 Apr 2016 06:04:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48759) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aoTGk-0002YB-99 for qemu-devel@nongnu.org; Fri, 08 Apr 2016 06:04:02 -0400 Date: Fri, 8 Apr 2016 18:03:55 +0800 From: Peter Xu Message-ID: <20160408100355.GE26923@pxdev.xzpeter.org> References: <1455852618-5224-1-git-send-email-peterx@redhat.com> <1455852618-5224-12-git-send-email-peterx@redhat.com> <56C9DE17.6020604@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <56C9DE17.6020604@gmail.com> Subject: Re: [Qemu-devel] [PATCH 11/13] intel_iommu: add IR translation faults defines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: marcel@redhat.com Cc: qemu-devel@nongnu.org, ehabkost@redhat.com, mst@redhat.com, jasowang@redhat.com, pbonzini@redhat.com, imammedo@redhat.com, rth@twiddle.net On Sun, Feb 21, 2016 at 05:56:07PM +0200, Marcel Apfelbaum wrote: > >+ > >+ /* > >+ * Interrupt remapping transition faults > >+ */ > >+ VTD_FR_IR_REQ_RSVD = 0x20, /* One or more IR request resved > >+ * fields set */ > > Hi, > > Minor comments: > resved -> reserved > > I would keep comments single line when possible > even on top of the code line. Will fix these in next version. Thanks. -- peterx