Re: [Qemu-devel] [PULL 48/48] iotests: Test qemu-img convert -S 0 behavior

[Fam Zheng <famz@redhat.com>]

On Fri, 04/08 12:21, Kevin Wolf wrote:
> Am 08.04.2016 um 03:18 hat Fam Zheng geschrieben:
> > On Thu, 04/07 16:40, Paolo Bonzini wrote:
> > > 
> > > 
> > > On 29/03/2016 17:08, Kevin Wolf wrote:
> > > > From: Max Reitz <mreitz@redhat.com>
> > > > 
> > > > Passing -S 0 to qemu-img convert should result in all source data being
> > > > copied to the output, even if that source data is known to be 0. The
> > > > output image should therefore have exactly the same size on disk as an
> > > > image which we explicitly filled with data.
> > > > 
> > > > Signed-off-by: Max Reitz <mreitz@redhat.com>
> > > > Reviewed-by: Fam Zheng <famz@redhat.com>
> > > > Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> > > 
> > > This fails with XFS and raw format, which preallocates an extra cluster
> > > at the end of the file created with qemu-io (so that the on-disk size is
> > > 2056 512-byte blocks).
> > 
> > Maybe squash in http://patchwork.ozlabs.org/patch/603047/ ?
> 
> It's too late to squash it in, but yes, that should be the fix for it.
> 

Yes, didn't know it's already merged.

Fam