From: Kevin Wolf <kwolf@redhat.com>
To: Sascha Silbe <silbe@linux.vnet.ibm.com>
Cc: Max Reitz <mreitz@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org,
Tu Bo <tubo@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 6/7] qemu-iotests: 141: reduce likelihood of race condition on systems with fast IO
Date: Fri, 8 Apr 2016 13:11:53 +0200 [thread overview]
Message-ID: <20160408111153.GD4700@noname.redhat.com> (raw)
In-Reply-To: <87shyxjh9w.fsf@oc4731375738.ibm.com>
Am 07.04.2016 um 22:27 hat Sascha Silbe geschrieben:
> Dear Max,
>
> Max Reitz <mreitz@redhat.com> writes:
>
> > On 05.04.2016 11:21, Sascha Silbe wrote:
> >> On systems with fast IO, qemu-io may write more than 1 MiB before
> >> receiving the block-job-cancel command, causing the test case to fail.
> >>
> >> 141 is inherently racy, but we can at least reduce the likelihood of the
> >> job completing before the cancel command arrives by bumping the size of
> >> the data getting written; we'll try 32 MiB for a start.
> >
> > Hm, interesting. I tried to prevent this by setting the block jobs'
> > speed to 1, which should make it stop after the block job has processed
> > the first block of data.
>
> Hmm, seems like I didn't quite understand the way the test works
> then.
>
> @Kevin: Please do NOT queue this patch.
No problem. I expect this series to go through Max's tree anyway.
Kevin
next prev parent reply other threads:[~2016-04-08 11:12 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-05 9:21 [Qemu-devel] [PATCH 0/7] next round of qemu-iotests fixes Sascha Silbe
2016-04-05 9:21 ` [Qemu-devel] [PATCH 1/7] qemu-iotests: check: don't place files with predictable names in /tmp Sascha Silbe
2016-04-06 15:36 ` [Qemu-devel] [Qemu-block] " Max Reitz
2016-04-07 19:54 ` Sascha Silbe
2016-04-05 9:21 ` [Qemu-devel] [PATCH 2/7] qemu-iotests: fix 051 on non-PC architectures Sascha Silbe
2016-04-06 15:43 ` [Qemu-devel] [Qemu-block] " Max Reitz
2016-04-05 9:21 ` [Qemu-devel] [PATCH 3/7] qemu-iotests: iotests.VM: remove qtest socket on error Sascha Silbe
2016-04-06 15:55 ` [Qemu-devel] [Qemu-block] " Max Reitz
2016-04-07 19:58 ` Sascha Silbe
2016-04-05 9:21 ` [Qemu-devel] [PATCH 4/7] qemu-iotests: 148: properly skip test if quorum support is missing Sascha Silbe
2016-04-06 16:04 ` [Qemu-devel] [Qemu-block] " Max Reitz
2016-04-05 9:21 ` [Qemu-devel] [PATCH 5/7] qemu-iotests: 068: don't require KVM Sascha Silbe
2016-04-06 16:12 ` [Qemu-devel] [Qemu-block] " Max Reitz
2016-04-05 9:21 ` [Qemu-devel] [PATCH 6/7] qemu-iotests: 141: reduce likelihood of race condition on systems with fast IO Sascha Silbe
2016-04-06 16:15 ` [Qemu-devel] [Qemu-block] " Max Reitz
2016-04-06 16:30 ` Kevin Wolf
2016-04-07 20:27 ` Sascha Silbe
2016-04-08 11:11 ` Kevin Wolf [this message]
2016-04-08 12:01 ` Sascha Silbe
2016-04-08 12:31 ` Kevin Wolf
2016-04-08 13:46 ` Sascha Silbe
2016-04-05 9:21 ` [Qemu-devel] [PATCH 7/7] qemu-iotests: iotests.py: get rid of __all__ Sascha Silbe
2016-04-06 16:18 ` [Qemu-devel] [Qemu-block] " Max Reitz
2016-04-08 14:49 ` [Qemu-devel] [Qemu-block] [PATCH 0/7] next round of qemu-iotests fixes Max Reitz
2016-04-08 17:17 ` Sascha Silbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160408111153.GD4700@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=silbe@linux.vnet.ibm.com \
--cc=tubo@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.