Re: [PATCH 3/4] libxl: only allow guests with a device model to use cd-{eject/insert}

[Wei Liu <wei.liu2@citrix.com>]

On Fri, Apr 08, 2016 at 04:17:55PM +0200, Roger Pau Monné wrote:
> On Fri, 8 Apr 2016, Wei Liu wrote:
> > On Thu, Apr 07, 2016 at 07:45:28PM +0200, Roger Pau Monne wrote:
> > > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> > > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > > Cc: Wei Liu <wei.liu2@citrix.com>
> > > ---
> > >  tools/libxl/libxl.c | 6 ++++++
> > >  1 file changed, 6 insertions(+)
> > > 
> > > diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
> > > index 9d785a4..232e2c1 100644
> > > --- a/tools/libxl/libxl.c
> > > +++ b/tools/libxl/libxl.c
> > > @@ -2909,6 +2909,12 @@ int libxl_cdrom_insert(libxl_ctx *ctx, uint32_t domid, libxl_device_disk *disk,
> > >          goto out;
> > >      }
> > >  
> > > +    if (dm_ver == LIBXL_DEVICE_MODEL_VERSION_NONE) {
> > > +        LOG(ERROR, "HVM guests without a device model cannot use cd-insert");
> > 
> > It's not specific to HVM, right?
> 
> It's specific to guests with a device model (those are the only ones that 
> can have an emulated CDROM device), and the only guests that can have a 
> device model are HVM (although not all of them).
> 

Remind me again: how does PV guest CDROM work? ISTR it will also go
through this function? My memory is vague though...

Wei.

> Roger.


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel