From: Christoph Hellwig <hch@infradead.org>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: Christoph Hellwig <hch@infradead.org>,
sagig@mellanox.com, linux-rdma@vger.kernel.org,
target-devel@vger.kernel.org
Subject: Re: T10 PI offloading seems to be broken in iser/isert in 4.5/4.6-rc
Date: Fri, 8 Apr 2016 17:14:56 -0700 [thread overview]
Message-ID: <20160409001456.GA1752@infradead.org> (raw)
In-Reply-To: <1460159290.901.5.camel@haakon3.risingtidesystems.com>
On Fri, Apr 08, 2016 at 04:48:10PM -0700, Nicholas A. Bellinger wrote:
> It looks like the isert_set_dif_domain() assignments of
> ib_sig_domain->sig.dif.* from dev->dev_attrib.block_size + friends is
> being zeroed before making it into mlx5_ib_post_send() ->
> IB_WR_REG_SIG_MR -> set_sig_umr_wr() -> set_sig_data_segment().
>From my limited understanding that's not the case, even if the weird
printk about the bad block size might suggest it.
I think what we have is the TARGET_PROT_DIN_INSERT /
TARGET_PROT_DOUT_STRIP case (probably the first), and thus
sig_attrs->mem.sig_type is set to IB_SIG_TYPE_NONE, but for some
reason the prot pointer is set, which will lead to this misleading
printk.
Does anyone know a recent working version of T10 PI in isert? There
aren't any recent-ish changes that look related.
next prev parent reply other threads:[~2016-04-09 0:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-08 22:15 T10 PI offloading seems to be broken in iser/isert in 4.5/4.6-rc Christoph Hellwig
2016-04-08 23:48 ` Nicholas A. Bellinger
2016-04-09 0:14 ` Christoph Hellwig [this message]
2016-04-09 2:36 ` Nicholas A. Bellinger
2016-04-09 4:58 ` Christoph Hellwig
[not found] ` <20160409045846.GA9269-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-04-10 8:53 ` Sagi Grimberg
2016-04-10 14:37 ` Christoph Hellwig
2016-04-10 15:30 ` Sagi Grimberg
[not found] ` <1460169374.5010.4.camel-XoQW25Eq2zviZyQQd+hFbcojREIfoBdhmpATvIKMPHk@public.gmane.org>
2016-04-10 8:42 ` sagig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160409001456.GA1752@infradead.org \
--to=hch@infradead.org \
--cc=linux-rdma@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=sagig@mellanox.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.