From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: optimizations to sk_buff handling in rds_tcp_data_ready
Date: Sat, 9 Apr 2016 20:18:53 -0400 [thread overview]
Message-ID: <20160410001853.GA30364@oracle.com> (raw)
In-Reply-To: <1460038560.6473.397.camel@edumazet-glaptop3.roam.corp.google.com>
On (04/07/16 07:16), Eric Dumazet wrote:
> Use skb split like TCP in output path ?
> Really, pskb_expand_head() is not supposed to copy payload ;)
Question- how come skb_split doesnt have to deal with frag_list
and do a skb_walk_frags()? Couldn't the split-line be somewhere
in the frag_list? Also even for the skb_split_inside_header,
dont we have to set
skb_shinfo(skb1)->frag_list = skb_shinfo(skb)->frag_list;
and cut loose the skb_shinfo(skb)->frag_list?
As I try to mimic skb_split in some new set of "skb_carve"
funtions, I'm running into all the various frag_list cases. I'm
afraid I might end up needing most of the stuff under the "Pure
masohism" (sic) comment in __pskb_pull_tail().
--Sowmini
next prev parent reply other threads:[~2016-04-10 0:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 13:11 optimizations to sk_buff handling in rds_tcp_data_ready Sowmini Varadhan
2016-04-07 14:16 ` Eric Dumazet
2016-04-07 19:29 ` Sowmini Varadhan
2016-04-10 0:18 ` Sowmini Varadhan [this message]
2016-04-10 23:54 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160410001853.GA30364@oracle.com \
--to=sowmini.varadhan@oracle.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.