From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard@free-electrons.com (Maxime Ripard) Date: Sun, 10 Apr 2016 02:16:30 -0700 Subject: [PATCH v3 01/19] clk: composite: Add unregister function In-Reply-To: <1458751122-23976-2-git-send-email-maxime.ripard@free-electrons.com> References: <1458751122-23976-1-git-send-email-maxime.ripard@free-electrons.com> <1458751122-23976-2-git-send-email-maxime.ripard@free-electrons.com> Message-ID: <20160410091630.GV4227@lukather> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Stephen, Mike, On Wed, Mar 23, 2016 at 05:38:24PM +0100, Maxime Ripard wrote: > The composite clock didn't have any unregistration function, which forced > us to use clk_unregister directly on it. > > While it was already not great from an API point of view, it also meant > that we were leaking the clk_composite structure allocated in > clk_register_composite. > > Add a clk_unregister_composite function to fix this. > > Signed-off-by: Maxime Ripard Any comment on this one ? (and the other clock patches) Thanks, Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH v3 01/19] clk: composite: Add unregister function Date: Sun, 10 Apr 2016 02:16:30 -0700 Message-ID: <20160410091630.GV4227@lukather> References: <1458751122-23976-1-git-send-email-maxime.ripard@free-electrons.com> <1458751122-23976-2-git-send-email-maxime.ripard@free-electrons.com> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="mgIE+9cwyCTt+85Z" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <1458751122-23976-2-git-send-email-maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Mike Turquette , Stephen Boyd Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Laurent Pinchart , Hans de Goede , Alexander Kaplan , Boris Brezillon , Thomas Petazzoni , Rob Clark , David Airlie , Thierry Reding , Rob Herring , Chen-Yu Tsai , Daniel Vetter List-Id: devicetree@vger.kernel.org --mgIE+9cwyCTt+85Z Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Hi Stephen, Mike, On Wed, Mar 23, 2016 at 05:38:24PM +0100, Maxime Ripard wrote: > The composite clock didn't have any unregistration function, which forced > us to use clk_unregister directly on it. > > While it was already not great from an API point of view, it also meant > that we were leaking the clk_composite structure allocated in > clk_register_composite. > > Add a clk_unregister_composite function to fix this. > > Signed-off-by: Maxime Ripard Any comment on this one ? (and the other clock patches) Thanks, Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --mgIE+9cwyCTt+85Z-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755440AbcDJP0B (ORCPT ); Sun, 10 Apr 2016 11:26:01 -0400 Received: from down.free-electrons.com ([37.187.137.238]:40493 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754291AbcDJPZ6 (ORCPT ); Sun, 10 Apr 2016 11:25:58 -0400 Date: Sun, 10 Apr 2016 02:16:30 -0700 From: Maxime Ripard To: Mike Turquette , Stephen Boyd Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-sunxi@googlegroups.com, Laurent Pinchart , Hans de Goede , Alexander Kaplan , Boris Brezillon , Thomas Petazzoni , Rob Clark , David Airlie , Thierry Reding , Rob Herring , Chen-Yu Tsai , Daniel Vetter Subject: Re: [PATCH v3 01/19] clk: composite: Add unregister function Message-ID: <20160410091630.GV4227@lukather> References: <1458751122-23976-1-git-send-email-maxime.ripard@free-electrons.com> <1458751122-23976-2-git-send-email-maxime.ripard@free-electrons.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="mgIE+9cwyCTt+85Z" Content-Disposition: inline In-Reply-To: <1458751122-23976-2-git-send-email-maxime.ripard@free-electrons.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --mgIE+9cwyCTt+85Z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Stephen, Mike, On Wed, Mar 23, 2016 at 05:38:24PM +0100, Maxime Ripard wrote: > The composite clock didn't have any unregistration function, which forced > us to use clk_unregister directly on it. >=20 > While it was already not great from an API point of view, it also meant > that we were leaking the clk_composite structure allocated in > clk_register_composite. >=20 > Add a clk_unregister_composite function to fix this. >=20 > Signed-off-by: Maxime Ripard Any comment on this one ? (and the other clock patches) Thanks, Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --mgIE+9cwyCTt+85Z Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXChnuAAoJEBx+YmzsjxAghacQAKBRoSerWi4c2JevpC4i/bst 0+wQx1XUDXJTl3dgUcd1MUaO+ymSvv+6G3KmdOVqfhiOJbPUof5Weh3q4SJC+sEV wlmHs33iqNynrSRxFoTkzbtonv8HKWFaubSwpvRIFitittnjk0JZ9BJXcP7lsWXo 4FMIIxPybD11J61KLvbTEx7vgxmy1dMiXljM0UwBVdEc79lxwvm/+Qk6nquqgRP/ 1Rf2mMmD2PVp/WimbPbtn1Av0ur67L0VdViuUIXnpXxyWOyK3X7Cl1YdcdYwbNEs vwLe3jP4nYEoeuUNnW6p/3Xldif5L8qc5gCySDJAn+Rig9ZIp68Fp/C5Uk10sT+8 bGfsgNXBUrHmTcCumFb+kVRBHan+5wQKKCyQWQDS/fxX+T4G/BRcJUSDuuDolZkN SiCM0wUTzgFlLy7C5VBAH2F9LbGuUuUsRkiACdZOUluwFM2lExlCoSvVwTUOTdec Go1s6WzT6Omikfrb122/CeXpcyBEKzXmesxaHrpQFhA/BDSLhznAMVlbUnqzu9Cp fkiCZxQxe27ThIuecsd+5PcsEA8FspQcQAI/Vbtb/mv7lV/bALFpvN/3/D3t8sKX MvtL1zECb8rjLIqHYntrFS/wkwY4YPLHVlc2hSl347slumMiPK13pVDUt2qyzq/9 I/l2Wowkw/ksW/iN9Eil =9jHH -----END PGP SIGNATURE----- --mgIE+9cwyCTt+85Z--