From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: rtc-linux@googlegroups.com, devicetree@vger.kernel.org,
Sergey Yanovich <ynvich@gmail.com>,
Alessandro Zummo <a.zummo@towertech.it>
Subject: [rtc-linux] Re: [PATCH 1/4] rtc: ds1302: fix error check in set_time
Date: Sun, 10 Apr 2016 17:17:33 +0200 [thread overview]
Message-ID: <20160410151733.GE5377@piout.net> (raw)
In-Reply-To: <1460300366-25248-2-git-send-email-akinobu.mita@gmail.com>
On 10/04/2016 at 23:59:23 +0900, Akinobu Mita wrote :
> The set_time callback for rtc-ds1302 doesn't write clock registers
> because the error check for the return value from spi_write_then_read()
> is not correct. spi_write_then_read() which returns zero on success.
>
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
> Cc: Sergey Yanovich <ynvich@gmail.com>
> Cc: Alessandro Zummo <a.zummo@towertech.it>
> Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> drivers/rtc/rtc-ds1302.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Akinobu Mita <akinobu.mita-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Sergey Yanovich <ynvich-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Alessandro Zummo
<a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org>
Subject: Re: [PATCH 1/4] rtc: ds1302: fix error check in set_time
Date: Sun, 10 Apr 2016 17:17:33 +0200 [thread overview]
Message-ID: <20160410151733.GE5377@piout.net> (raw)
In-Reply-To: <1460300366-25248-2-git-send-email-akinobu.mita-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On 10/04/2016 at 23:59:23 +0900, Akinobu Mita wrote :
> The set_time callback for rtc-ds1302 doesn't write clock registers
> because the error check for the return value from spi_write_then_read()
> is not correct. spi_write_then_read() which returns zero on success.
>
> Signed-off-by: Akinobu Mita <akinobu.mita-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Cc: Sergey Yanovich <ynvich-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Cc: Alessandro Zummo <a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org>
> Cc: Alexandre Belloni <alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
> ---
> drivers/rtc/rtc-ds1302.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-04-10 15:17 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-10 14:59 [rtc-linux] [PATCH 0/4] support control with using GPIO lines Akinobu Mita
2016-04-10 14:59 ` Akinobu Mita
2016-04-10 14:59 ` [rtc-linux] [PATCH 1/4] rtc: ds1302: fix error check in set_time Akinobu Mita
2016-04-10 14:59 ` Akinobu Mita
2016-04-10 15:17 ` Alexandre Belloni [this message]
2016-04-10 15:17 ` Alexandre Belloni
2016-04-10 14:59 ` [rtc-linux] [PATCH 2/4] rtc: ds1302: fix write value for day of week register Akinobu Mita
2016-04-10 14:59 ` Akinobu Mita
2016-04-10 15:17 ` [rtc-linux] " Alexandre Belloni
2016-04-10 15:17 ` Alexandre Belloni
2016-04-10 14:59 ` [rtc-linux] [PATCH 3/4] rtc: ds1302: add register access abstraction layer Akinobu Mita
2016-04-10 14:59 ` Akinobu Mita
2016-04-10 14:59 ` [rtc-linux] [PATCH 4/4] rtc: ds1302: support control with using GPIO lines Akinobu Mita
2016-04-10 14:59 ` Akinobu Mita
2016-04-10 15:12 ` [rtc-linux] Re: [PATCH 0/4] " Alexandre Belloni
2016-04-10 15:12 ` Alexandre Belloni
2016-04-10 15:23 ` [rtc-linux] " Sergei Ianovich
2016-04-10 15:23 ` Sergei Ianovich
2016-04-10 15:38 ` [rtc-linux] " Alexandre Belloni
2016-04-10 15:38 ` Alexandre Belloni
2016-04-12 1:25 ` [rtc-linux] " Mark Brown
2016-04-12 1:25 ` Mark Brown
2016-04-26 19:53 ` [rtc-linux] " Akinobu Mita
2016-04-26 19:53 ` Akinobu Mita
2016-04-27 13:50 ` [rtc-linux] " Mark Brown
2016-04-27 13:50 ` Mark Brown
2016-04-27 14:03 ` [rtc-linux] " Sergei Ianovich
2016-04-27 14:03 ` Sergei Ianovich
2016-04-29 5:40 ` [rtc-linux] " Akinobu Mita
2016-04-29 5:40 ` Akinobu Mita
2016-06-26 0:55 ` [rtc-linux] " Alexandre Belloni
2016-06-26 0:55 ` Alexandre Belloni
2016-06-27 10:23 ` [rtc-linux] " Akinobu Mita
2016-06-27 10:23 ` Akinobu Mita
2016-04-11 19:46 ` [rtc-linux] " Rob Herring
2016-04-11 19:46 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160410151733.GE5377@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=akinobu.mita@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=ynvich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.