From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: rtc-linux@googlegroups.com Received: from mail.free-electrons.com (down.free-electrons.com. [37.187.137.238]) by gmr-mx.google.com with ESMTP id i196si316188wmf.0.2016.04.10.08.17.45 for ; Sun, 10 Apr 2016 08:17:45 -0700 (PDT) Date: Sun, 10 Apr 2016 17:17:45 +0200 From: Alexandre Belloni To: Akinobu Mita Cc: rtc-linux@googlegroups.com, devicetree@vger.kernel.org, Sergey Yanovich , Alessandro Zummo Subject: [rtc-linux] Re: [PATCH 2/4] rtc: ds1302: fix write value for day of week register Message-ID: <20160410151745.GF5377@piout.net> References: <1460300366-25248-1-git-send-email-akinobu.mita@gmail.com> <1460300366-25248-3-git-send-email-akinobu.mita@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: <1460300366-25248-3-git-send-email-akinobu.mita@gmail.com> Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On 10/04/2016 at 23:59:24 +0900, Akinobu Mita wrote : > The valid range of day of week register for DS1302 is 1 to 7. But the > set_time callback for rtc-ds1302 attempts to write the value of > tm->tm_wday which is in the range 0 to 6. While the get_time callback > correctly decodes the register. > > Signed-off-by: Akinobu Mita > Cc: Sergey Yanovich > Cc: Alessandro Zummo > Cc: Alexandre Belloni > --- > drivers/rtc/rtc-ds1302.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Subject: Re: [PATCH 2/4] rtc: ds1302: fix write value for day of week register Date: Sun, 10 Apr 2016 17:17:45 +0200 Message-ID: <20160410151745.GF5377@piout.net> References: <1460300366-25248-1-git-send-email-akinobu.mita@gmail.com> <1460300366-25248-3-git-send-email-akinobu.mita@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1460300366-25248-3-git-send-email-akinobu.mita-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Akinobu Mita Cc: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Sergey Yanovich , Alessandro Zummo List-Id: devicetree@vger.kernel.org On 10/04/2016 at 23:59:24 +0900, Akinobu Mita wrote : > The valid range of day of week register for DS1302 is 1 to 7. But the > set_time callback for rtc-ds1302 attempts to write the value of > tm->tm_wday which is in the range 0 to 6. While the get_time callback > correctly decodes the register. > > Signed-off-by: Akinobu Mita > Cc: Sergey Yanovich > Cc: Alessandro Zummo > Cc: Alexandre Belloni > --- > drivers/rtc/rtc-ds1302.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html