Re: [PATCH 1/1] base.bbclass: fix COMPATIBLE_MACHINE

[Denys Dmytriyenko <denis@denix.org>]

On Sun, Apr 10, 2016 at 07:14:56AM -0700, Robert Yang wrote:
> It mismatched such as qemux86 and qemux86-64 which was incorrect, for
> example:
> COMPATIBLE_MACHINE = "(qemux86)"

That will match qemux86 and qemux86-64 and is by design! It's a regular 
expression, not an exact string match! There are plenty of recipes 
(especially outside of oe-core) that depend on this behavior, so please don't 
break it!


> But it treated MACHINE = "qemux86-64" as matched. The similar to others.
> 
> This patch fixes the problem.
> 
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
>  meta/classes/base.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
> index f9697a9..f376478 100644
> --- a/meta/classes/base.bbclass
> +++ b/meta/classes/base.bbclass
> @@ -469,7 +469,7 @@ python () {
>          import re
>          compat_machines = (d.getVar('MACHINEOVERRIDES', True) or "").split(":")
>          for m in compat_machines:
> -            if re.match(need_machine, m):
> +            if re.match('^' + need_machine + '$', m):
>                  break
>          else:
>              raise bb.parse.SkipPackage("incompatible with machine %s (not in COMPATIBLE_MACHINE)" % d.getVar('MACHINE', True))
> -- 
> 2.8.0
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core