From: 'Leon Romanovsky' <leon-2ukJVAZIZ/Y@public.gmane.org>
To: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
Cc: Steve Wise
<swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>,
'Mustafa Ismail'
<mustafa.ismail-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
e1000-rdma-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [RDMA PATCH 16/16] i40iw: Adding queue drain functions
Date: Mon, 11 Apr 2016 07:50:37 +0300 [thread overview]
Message-ID: <20160411045037.GF20252@leon.nu> (raw)
In-Reply-To: <570AA8D0.2060404-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 482 bytes --]
On Sun, Apr 10, 2016 at 10:26:08PM +0300, Sagi Grimberg wrote:
> I do understand Leon when he sees 3 copies of this code, but all these
> copies are looking into the raw queue so I'm fine with it.
Despite the fact that I understand the reasoning behind this specific
implementation, it makes me wonder when will we see common implementation
for this type of queues?
We saw 3 similar implementations, in near future, we will get another
one and I believe that it won't stop there.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-04-11 4:50 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 16:30 [RDMA PATCH 00/16] Intel X722 iWARP driver update Mustafa Ismail
[not found] ` <1460046664-552-1-git-send-email-mustafa.ismail-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-04-07 16:30 ` [RDMA PATCH 01/16] i40iw: Fix overflow of region length Mustafa Ismail
[not found] ` <1460046664-552-2-git-send-email-mustafa.ismail-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-04-11 9:23 ` Leon Romanovsky
[not found] ` <20160411092324.GG20252-2ukJVAZIZ/Y@public.gmane.org>
2016-04-12 18:09 ` Mustafa Ismail
2016-04-07 16:30 ` [RDMA PATCH 02/16] i40iw: Correct QP size calculation Mustafa Ismail
2016-04-07 16:30 ` [RDMA PATCH 03/16] i40iw: Fix refused connections Mustafa Ismail
2016-04-07 16:30 ` [RDMA PATCH 04/16] i40iw: Correct max message size in query port Mustafa Ismail
2016-04-07 16:30 ` [RDMA PATCH 05/16] i40iw: Do not set self-referencing pointer to NULL after free Mustafa Ismail
2016-04-07 16:30 ` [RDMA PATCH 06/16] i40iw: Add qp table lock around AE processing Mustafa Ismail
2016-04-07 16:30 ` [RDMA PATCH 07/16] i40iw: Set vendor_err only if there is an actual error Mustafa Ismail
2016-04-07 16:30 ` [RDMA PATCH 08/16] i40iw: Populate vendor_id and vendor_part_id fields Mustafa Ismail
2016-04-07 16:30 ` [RDMA PATCH 09/16] i40iw: Remove unused code and fix warning Mustafa Ismail
2016-04-07 16:30 ` [RDMA PATCH 10/16] i40iw: Add virtual channel message queue Mustafa Ismail
2016-04-07 16:30 ` [RDMA PATCH 11/16] i40iw: Correct return code check in add_pble_pool Mustafa Ismail
2016-04-07 16:31 ` [RDMA PATCH 12/16] i40iw: Initialize max enabled vfs variable Mustafa Ismail
2016-04-07 16:31 ` [RDMA PATCH 13/16] i40iw: Add base memory management extensions Mustafa Ismail
[not found] ` <1460046664-552-14-git-send-email-mustafa.ismail-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-04-12 14:07 ` Christoph Hellwig
[not found] ` <20160412140739.GA23302-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-04-12 18:13 ` Mustafa Ismail
2016-04-07 16:31 ` [RDMA PATCH 14/16] i40iw: Fix endian issues and warnings Mustafa Ismail
2016-04-07 16:31 ` [RDMA PATCH 15/16] i40iw: Fix SD calculation for initial HMC creation Mustafa Ismail
2016-04-07 16:31 ` [RDMA PATCH 16/16] i40iw: Adding queue drain functions Mustafa Ismail
[not found] ` <1460046664-552-17-git-send-email-mustafa.ismail-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-04-08 0:46 ` Leon Romanovsky
[not found] ` <20160408004638.GD20252-2ukJVAZIZ/Y@public.gmane.org>
2016-04-08 18:44 ` Mustafa Ismail
2016-04-08 22:15 ` Steve Wise
2016-04-10 19:26 ` Sagi Grimberg
[not found] ` <570AA8D0.2060404-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-04-11 4:50 ` 'Leon Romanovsky' [this message]
2016-04-12 10:27 ` [RDMA PATCH 00/16] Intel X722 iWARP driver update Or Gerlitz
[not found] ` <CALq1K=L4fdgLxL+-2vNfX0SUvrS9ShTgS=vDOpZyJDyK8EHB=Q@mail.gmail.com>
2016-04-12 4:33 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160411045037.GF20252@leon.nu \
--to=leon-2ukjvaziz/y@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=e1000-rdma-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mustafa.ismail-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org \
--cc=swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.