All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [for-CI] Revert "drm/i915: Limit the auto arming of mmio debugs on vlv/chv"
Date: Mon, 11 Apr 2016 16:31:28 +0300	[thread overview]
Message-ID: <20160411133128.GE4329@intel.com> (raw)
In-Reply-To: <1460380861-5493-1-git-send-email-chris@chris-wilson.co.uk>

On Mon, Apr 11, 2016 at 02:21:01PM +0100, Chris Wilson wrote:
> This reverts commit c81eeea6c14b212016104f4256c65f93ad230a86.

Not quite yet. I have patches pretty much line up to fix the resulting
spew. Just got a bit sidetracked by the CHV irq problems.

> ---
>  drivers/gpu/drm/i915/intel_uncore.c | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
> index ac2ac07b505b..2f7fb7d169b8 100644
> --- a/drivers/gpu/drm/i915/intel_uncore.c
> +++ b/drivers/gpu/drm/i915/intel_uncore.c
> @@ -633,15 +633,6 @@ __unclaimed_reg_debug(struct drm_i915_private *dev_priv,
>  		      const bool read,
>  		      const bool before)
>  {
> -	/* XXX. We limit the auto arming traces for mmio
> -	 * debugs on these platforms. There are just too many
> -	 * revealed by these and CI/Bat suffers from the noise.
> -	 * Please fix and then re-enable the automatic traces.
> -	 */
> -	if (i915.mmio_debug < 2 &&
> -	    (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv)))
> -		return;
> -
>  	if (WARN(check_for_unclaimed_mmio(dev_priv),
>  		 "Unclaimed register detected %s %s register 0x%x\n",
>  		 before ? "before" : "after",
> -- 
> 2.8.0.rc3
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2016-04-11 13:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-11 13:21 [for-CI] Revert "drm/i915: Limit the auto arming of mmio debugs on vlv/chv" Chris Wilson
2016-04-11 13:31 ` Ville Syrjälä [this message]
2016-04-11 13:37   ` Chris Wilson
2016-04-11 13:54     ` Ville Syrjälä
2016-04-11 14:07 ` ✗ Fi.CI.BAT: failure for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160411133128.GE4329@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.