From: Mike Snitzer <snitzer@redhat.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Alasdair Kergon <agk@redhat.com>, Shaohua Li <shli@kernel.org>,
linux-kernel@vger.kernel.org, dm-devel@redhat.com,
linux-raid@vger.kernel.org
Subject: Re: dm: ioctl: use kvfree
Date: Mon, 11 Apr 2016 11:17:15 -0400 [thread overview]
Message-ID: <20160411151714.GB25938@redhat.com> (raw)
In-Reply-To: <1460387677-19948-1-git-send-email-sudipm.mukherjee@gmail.com>
On Mon, Apr 11 2016 at 11:14am -0400,
Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote:
> We can use kvfree() instead of calling kfree() and vfree() based on
> if-else and param_flags. kvfree() will check the type of address and
> will call the respective function to free it.
> Additionally we can also remove the use of DM_PARAMS_KMALLOC and
> DM_PARAMS_VMALLOC.
>
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Have you actually tested htis? Last time I looked to do this it exposed
crashes. I don't have time to dig into this again right now but this is
_not_ as simple as this patch implies.
next prev parent reply other threads:[~2016-04-11 15:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-11 15:14 [PATCH] dm: ioctl: use kvfree Sudip Mukherjee
2016-04-11 15:17 ` Mike Snitzer [this message]
2016-04-11 16:09 ` Sudip Mukherjee
2016-04-11 19:52 ` Rasmus Villemoes
2016-04-11 18:34 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160411151714.GB25938@redhat.com \
--to=snitzer@redhat.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=shli@kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.